Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PubSub emulator 0.8.2 #6916

Merged
merged 2 commits into from
Mar 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update to PubSub emulator 0.8.2
  • Loading branch information
joehan committed Mar 26, 2024
commit 75a05b903668c25e5ea0e883f0bd1428c1c64054
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
- Release Firestore Emulator 1.19.4. This version fixes a minor bug with reserve ids and adds a `reset` endpoint for Datastore Mode.
- Released Firestore Emulator 1.19.4. This version fixes a minor bug with reserve ids and adds a `reset` endpoint for Datastore Mode.
- Released PubSub Emulator 0.8.2. This version includes support for `no_wrapper` options.
6 changes: 3 additions & 3 deletions src/emulator/downloadableEmulators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@
expectedChecksum: "49f6dc1911dda9d10df62a6c09aaf9a0",
},
pubsub: {
version: "0.7.1",
expectedSize: 65137179,
expectedChecksum: "b59a6e705031a54a69e5e1dced7ca9bf",
version: "0.8.2",
expectedSize: 65611398,
expectedChecksum: "70bb840321423e6ae621a3ae2f314903",
},
};

Expand Down Expand Up @@ -221,7 +221,7 @@
joinArgs: false,
},
pubsub: {
binary: getExecPath(Emulators.PUBSUB)!,

Check warning on line 224 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Forbidden non-null assertion
args: [],
optionalArgs: ["port", "host"],
joinArgs: true,
Expand All @@ -240,7 +240,7 @@
}

/**
* @param name

Check warning on line 243 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Missing JSDoc @param "name" description
*/
export function getLogFileName(name: string): string {
return `${name}-debug.log`;
Expand All @@ -253,7 +253,7 @@
*/
export function _getCommand(
emulator: DownloadableEmulators,
args: { [s: string]: any },

Check warning on line 256 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unexpected any. Specify a different type
): DownloadableEmulatorCommand {
const baseCmd = Commands[emulator];

Expand All @@ -267,7 +267,7 @@
if (
baseCmd.binary === "java" &&
utils.isRunningInWSL() &&
(!args.host || !args.host.includes(":"))

Check warning on line 270 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe member access .includes on an `any` value

Check warning on line 270 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe call of an `any` typed value
) {
// HACK(https://github.com/firebase/firebase-tools-ui/issues/332): Force
// Java to use IPv4 sockets in WSL (unless IPv6 address explicitly used).
Expand All @@ -286,7 +286,7 @@
}

const argKey = "--" + key;
const argVal = args[key];

Check warning on line 289 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe assignment of an `any` value

if (argVal === undefined) {
logger.log("DEBUG", `Ignoring empty arg for key: ${key}`);
Expand All @@ -295,9 +295,9 @@

// Sigh ... RTDB emulator needs "--arg val" and PubSub emulator needs "--arg=val"
if (baseCmd.joinArgs) {
cmdLineArgs.push(`${argKey}=${argVal}`);

Check warning on line 298 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Invalid type "any" of template literal expression
} else {
cmdLineArgs.push(argKey, argVal);

Check warning on line 300 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe argument of type `any` assigned to a parameter of type `string`
}
});

Expand Down Expand Up @@ -329,9 +329,9 @@
/**
* Handle errors in an emulator process.
*/
export async function handleEmulatorProcessError(emulator: Emulators, err: any): Promise<void> {

Check warning on line 332 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unexpected any. Specify a different type
const description = Constants.description(emulator);
if (err.path === "java" && err.code === "ENOENT") {

Check warning on line 334 in src/emulator/downloadableEmulators.ts

View workflow job for this annotation

GitHub Actions / lint (20)

Unsafe member access .path on an `any` value
await _fatal(
emulator,
`${description} has exited because java is not installed, you can install it from https://openjdk.java.net/install/`,
Expand Down
Loading