Switching a few more places to getters

src/api.ts

@@ -5,41 +5,36 @@
 
 let commandScopes = new Set<string>();
 
 export const authProxyOrigin = () =>
   utils.envOverride("FIREBASE_AUTHPROXY_URL", "https://auth.firebase.tools");
 // "In this context, the client secret is obviously not treated as a secret"
 // https://developers.google.com/identity/protocols/OAuth2InstalledApp
 export const clientId = () =>
   utils.envOverride(
     "FIREBASE_CLIENT_ID",
     "563584335869-fgrhgmd47bqnekij5i8b5pr03ho849e6.apps.googleusercontent.com",
   );
 export const clientSecret = () =>
   utils.envOverride("FIREBASE_CLIENT_SECRET", "j9iVZfS8kkCEFUPaAeJV0sAi");
 export const cloudbillingOrigin = () =>
   utils.envOverride("FIREBASE_CLOUDBILLING_URL", "https://cloudbilling.googleapis.com");
 export const cloudloggingOrigin = () =>
   utils.envOverride("FIREBASE_CLOUDLOGGING_URL", "https://logging.googleapis.com");
 export const cloudMonitoringOrigin = () =>
   utils.envOverride("CLOUD_MONITORING_URL", "https://monitoring.googleapis.com");
 export const containerRegistryDomain = () =>
   utils.envOverride("CONTAINER_REGISTRY_DOMAIN", "gcr.io");
 export const artifactRegistryDomain = () =>
   utils.envOverride("ARTIFACT_REGISTRY_DOMAIN", "https://artifactregistry.googleapis.com");
 export const appDistributionOrigin = () =>
   utils.envOverride(
     "FIREBASE_APP_DISTRIBUTION_URL",
     "https://firebaseappdistribution.googleapis.com",
   );
 export const authOrigin = () =>
   utils.envOverride("FIREBASE_AUTH_URL", "https://accounts.google.com");
 export const consoleOrigin = () =>
   utils.envOverride("FIREBASE_CONSOLE_URL", "https://console.firebase.google.com");
-export const deployOrigin = () =>
-  utils.envOverride(
-    "FIREBASE_DEPLOY_URL",
-    utils.envOverride("FIREBASE_UPLOAD_URL", "https://deploy.firebase.com"),
-  );
 export const dynamicLinksOrigin = () =>
   utils.envOverride("FIREBASE_DYNAMIC_LINKS_URL", "https://firebasedynamiclinks.googleapis.com");
 export const dynamicLinksKey = () =>

src/gcp/devConnect.ts

@@ -254,5 +254,5 @@ export async function getGitRepositoryLink(
  * Returns email associated with the Developer Connect Service Agent
  */
 export function serviceAgentEmail(projectNumber: string): string {
-  return `service-${projectNumber}@${developerConnectP4SAOrigin}`;
+  return `service-${projectNumber}@${developerConnectP4SAOrigin()}`;
 }

src/gcp/identityPlatform.ts

@@ -5,7 +5,7 @@ import { Client } from "../apiv2";
 const API_VERSION = "v2";
 
 const adminApiClient = new Client({
-  urlPrefix: identityOrigin + "/admin",
+  urlPrefix: identityOrigin() + "/admin",
   apiVersion: API_VERSION,
 });
 

src/init/features/hosting/github.ts

@@ -206,7 +206,7 @@ export async function initGitHub(setup: Setup): Promise<void> {
     `Visit this URL to revoke authorization for the Firebase CLI GitHub OAuth App:`,
   );
   logger.info(
-    bold(underline(`https://github.com/settings/connections/applications/${githubClientId}`)),
+    bold(underline(`https://github.com/settings/connections/applications/${githubClientId()}`)),
   );
   logLabeledBullet("Action required", `Push any new workflow file(s) to your repo`);
 }
@@ -442,7 +442,9 @@ async function promptForRepo(
             );
             logger.info(
               bold(
-                underline(`https://github.com/settings/connections/applications/${githubClientId}`),
+                underline(
+                  `https://github.com/settings/connections/applications/${githubClientId()}`,
+                ),
               ),
             );
             logger.info();