Skip to content

Add Service Usage Consumer role to GitHub Actions service account #6895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joehan merged 3 commits into from
Mar 26, 2024
Merged

Add Service Usage Consumer role to GitHub Actions service account #6895

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5dd58f
Add Service Usage Consumer role to GitHub Actions service account
aalej Mar 20, 2024
0524b25
Added a changelog entry
aalej Mar 20, 2024
146333d
Merge branch 'master' into aalej-gha-sa-role
aalej Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fixes issue where GitHub actions service account cannot add preview URLs to Auth authorized domains (#6895)
1 change: 1 addition & 0 deletions src/gcp/resourceManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export const firebaseRoles = {
functionsDeveloper: "roles/cloudfunctions.developer",
hostingAdmin: "roles/firebasehosting.admin",
runViewer: "roles/run.viewer",
serviceUsageConsumer: "roles/serviceusage.serviceUsageConsumer",
};

/**
Expand Down
4 changes: 4 additions & 0 deletions src/init/features/hosting/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,10 @@ async function createServiceAccountAndKey(
// https://github.com/firebase/firebase-tools/issues/2732
firebaseRoles.authAdmin,

// Required to add preview URLs to Auth authorized domains
// https://github.com/firebase/firebase-tools/issues/6828
firebaseRoles.serviceUsageConsumer,

// Required for CLI deploys
firebaseRoles.apiKeysViewer,

Expand Down