_name might be undefined, handle #5786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoortizz
approved these changes
May 3, 2023
Member
leoortizz
left a comment
leoortizz
left a comment
There was a problem hiding this comment.
LGTM! Left a refactor nit that can reduce the amount of code there
Comment on lines
306
to
+308
| context._name === "serve" || | ||
| context._name.startsWith("emulators:") | ||
| context._name === "emulators:start" || | ||
| context._name === "emulators:exec" |
Member
There was a problem hiding this comment.
refactor nit
Suggested change
| context._name === "serve" || | |
| context._name.startsWith("emulators:") | |
| context._name === "emulators:start" || | |
| context._name === "emulators:exec" | |
| ["serve", "emulators:start", "emulators:exec"].includes(context._name) |
davideast
approved these changes
May 3, 2023
Member
davideast
left a comment
davideast
left a comment
There was a problem hiding this comment.
LGTM. Tested the fix on my machine and it worked.
ProfHercules
pushed a commit
to ProfHercules/firebase-tools
that referenced
this pull request
May 5, 2023
Broke web frameworks deploy in the midnight effort to fix the emulators. Quick fix.
tonyjhuang
pushed a commit
that referenced
this pull request
May 22, 2023
Broke web frameworks deploy in the midnight effort to fix the emulators. Quick fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scenarios Tested
Sample Commands