Do multi-path PATCH instead of PUT in database:import
#5735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5735 +/- ##
==========================================
- Coverage 55.21% 54.62% -0.59%
==========================================
Files 325 325
Lines 22218 22790 +572
Branches 4521 4769 +248
==========================================
+ Hits 12267 12450 +183
- Misses 8863 9243 +380
- Partials 1088 1097 +9
☔ View full report in Codecov by Sentry. |
fredzqm
requested changes
Apr 26, 2023
tohhsinpei
force-pushed
the
hsinpei/database-chunk-4
branch
from
cb695d4 to
a48cb55
Compare
tohhsinpei
commented
Apr 27, 2023
fredzqm
reviewed
Apr 27, 2023
fredzqm
reviewed
Apr 28, 2023
fredzqm
approved these changes
May 3, 2023
fredzqm
reviewed
May 3, 2023
joehan
approved these changes
May 3, 2023
ProfHercules
pushed a commit
to ProfHercules/firebase-tools
that referenced
this pull request
May 5, 2023
…#5735) * Retry non-fatal ETIMEDOUT error in database:import * Add unit test * Do multi-path PATCH instead of PUT in database:import * Extract longest common prefix from pathnames in batch * Fix lint * Count and store data size when chunking * Fix lint * Compact batch before push instead of pairwise while streaming --------- Co-authored-by: joehan <joehanley@google.com>
tonyjhuang
pushed a commit
that referenced
this pull request
May 22, 2023
* Retry non-fatal ETIMEDOUT error in database:import * Add unit test * Do multi-path PATCH instead of PUT in database:import * Extract longest common prefix from pathnames in batch * Fix lint * Count and store data size when chunking * Fix lint * Compact batch before push instead of pairwise while streaming --------- Co-authored-by: joehan <joehanley@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
b/278767412
Context