Allow user to configure database:import chunk size and concurrency
#5726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5726 +/- ##
==========================================
- Coverage 55.58% 55.58% -0.01%
==========================================
Files 324 324
Lines 21977 21975 -2
Branches 4480 4479 -1
==========================================
- Hits 12217 12215 -2
Misses 8679 8679
Partials 1081 1081
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
joehan
approved these changes
Apr 25, 2023
| private dataPath: string, | ||
| private chunkSize = MAX_CHUNK_SIZE | ||
| private chunkBytes: number, | ||
| concurrency: number |
Contributor
There was a problem hiding this comment.
Any reason this can't be private as well?
Member
Author
There was a problem hiding this comment.
It can be; I just don't need it outside of the constructor.
ProfHercules
pushed a commit
to ProfHercules/firebase-tools
that referenced
this pull request
May 5, 2023
…irebase#5726) * Allow user to configure database:import chunk size and concurrency * Cap chunk size at NGINX max payload size
tonyjhuang
pushed a commit
that referenced
this pull request
May 22, 2023
…5726) * Allow user to configure database:import chunk size and concurrency * Cap chunk size at NGINX max payload size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
b/278767412
API proposal: go/firebase-database-import
Sample Commands