Ensure spec.params and spec.systemParams are not empty #5715
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5715 +/- ##
=======================================
Coverage 55.58% 55.59%
=======================================
Files 324 324
Lines 21973 21975 +2
Branches 4477 4479 +2
=======================================
+ Hits 12213 12216 +3
+ Misses 8679 8678 -1
Partials 1081 1081
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
|
||
| const [immutableParams, tbdParams] = partition( | ||
| spec.params.concat(spec.systemParams ?? []), | ||
| (spec.params ?? []).concat(spec.systemParams ?? []), |
There was a problem hiding this comment.
Do we need these checks here if we are checking it at the api level?
There was a problem hiding this comment.
Not really - this is just some extra defensive null checking in case we reintroduce this in the future accidentally. I have a low priority goal to make ext:install and ext:configure work offline for local extensions, and doing so could skip over the code in extensionsApi that ensures these are populated.
3 participants
Description
Due to the conversion to and from proto wire format, required repeated fields of extensionSpec would be undefined instead of empty. This caused some unexpected behavior, including erroring out when trying to ext:install or ext:configure an extension that has no params.
This change ensures that spec.param and spec.systemParams will be [] instead of undefined, and adds some defensive checking in other places to prevent similar issues.