Vite and NPM workspace fixes #5640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdaniels
commented
Mar 30, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5640 +/- ##
==========================================
- Coverage 55.92% 55.91% -0.02%
==========================================
Files 322 322
Lines 21706 21719 +13
Branches 4427 4431 +4
==========================================
+ Hits 12140 12145 +5
- Misses 8501 8508 +7
- Partials 1065 1066 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
leoortizz
reviewed
Apr 3, 2023
ProfHercules
pushed a commit
to ProfHercules/firebase-tools
that referenced
this pull request
May 5, 2023
* Better error message if a framework isn't detected * Handle NPM workspaces for both Vite and Angular * Error if the node_module binary isn't found * Force vite build to production mode ------ Co-authored-by: Tatsuya Yamamoto <TatsuyaYamamoto@users.noreply.github.com>
tonyjhuang
pushed a commit
that referenced
this pull request
May 22, 2023
* Better error message if a framework isn't detected * Handle NPM workspaces for both Vite and Angular * Error if the node_module binary isn't found * Force vite build to production mode ------ Co-authored-by: Tatsuya Yamamoto <TatsuyaYamamoto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail detection for vite if the config can't be loaded (seeing this with SvelteKit mostly)