Firebase Rules Deploy may not deploy rules when project has multiple databases

[TomasMorton]

[REQUIRED] Environment info

15.3.1 (local dev build: 40df2d6)

firebase-tools:

Platform:
Linux (Debian)

[REQUIRED] Test case

See #7981, it's a similar problem.

[REQUIRED] Steps to reproduce

Prerequisites: multiple databases

# Download existing rules
firebase init firestore 
# TODO: Modify the rules to those of another database
# Deploy the rules
firebase deploy --only 'firestore:d:rules' --debug
# You may see `latest version of firestore.rules already up to date, skipping upload...`.

[REQUIRED] Expected behavior

The modified rules are deployed

[REQUIRED] Actual behavior

The modified rules may be skipped

Details

As noted above, similar to #7981, we are using getLatestRulesetName() to get the rules, which does not filter by database and so is indeterministic about which rules it actually downloads.

[TomasMorton]

Opened TomasMorton#1 as a working solution to #7981. The fix for this one is a bit more involved though and I don't have time to finish it right now.

[aalej]

Thanks for the report and for sharing a fix to another issue @TomasMorton! As you mentioned, I think this is occurring since getLatestRulesetName() does not filter for the specific database. Taking a look, my guess is since listAllReleases sorts by creation time

firebase-tools/src/gcp/rules.ts

Lines 85 to 96 in 2db9277

	export async function listAllReleases(projectId: string): Promise<Release[]> {
	let pageToken;
	let releases: Release[] = [];
	do {
	const response: ListReleasesResponse = await listReleases(projectId, pageToken);
	if (response.releases && response.releases.length > 0) {
	releases = releases.concat(response.releases);
	}
	pageToken = response.nextPageToken;
	} while (pageToken);
	return releases.sort((a, b) => b.createTime.localeCompare(a.createTime));
	}

and since the getLatestRulesetName() method uses only a prefix(projects/PROJECT_ID/releases/cloud.firestore) for the resource name

firebase-tools/src/gcp/rules.ts

Lines 28 to 37 in 2db9277

	export async function getLatestRulesetName(
	projectId: string,
	service: string,
	resourceName?: string,
	): Promise<string | null> {
	const releases = await listAllReleases(projectId);
	let prefix = `projects/${projectId}/releases/${service}`;
	if (resourceName) {
	prefix += `/${resourceName}`;
	}

The latestRulesetContent value here would always be the rules from the most recently created database

firebase-tools/src/rulesDeploy.ts

Lines 168 to 171 in 2db9277

	const { latestName: latestRulesetName, latestContent: latestRulesetContent } =
	await this.getCurrentRules(service);

So if the rules you're trying to deploy matches the rules from the latest database, it shows the latest version of firestore.rules already up to date, skipping upload... message.

One odd thing to note is that even with the message being shown, the rules still seem to get deployed to the database - is this similar to what you've observed?

Feel free to open up a PR whenever you're ready so that we can take a look and review!

[TomasMorton]

That sounds correct, thanks for adding the details. As far as I know it didn't deploy, but I can't guarantee that.

I'll wait for your PR #9829 , as any solution to this will rely on that. I also can't prioritize work on rules right now.