Skip to content

missing spaces in error output related to cleanup policy #8413

@brantgurga

Description

@brantgurga

[REQUIRED] Environment info

firebase-tools:
14.1.0

Platform:
Linux

[REQUIRED] Test case

Run firebase deploy --only functions from an account without the artifactregistry.repositories.update permission and for which no cleanup policy is set up. When prompted to set up a policy and how many days, accept the default 1 day value.

[REQUIRED] Steps to reproduce

Run the command as indicated.

[REQUIRED] Expected behavior

Error has proper spacing.

[REQUIRED] Actual behavior

Error is missing a spaces between sentences and the space in 'orrun' that should be 'or run'.
Line 294 in

`Functions successfully deployed but could not set up cleanup policy in ` +
appears relevant. Looks like the space is there.
Similar code is at line 200 in
`Functions successfully deployed but could not set up cleanup policy in ` +
and that seems to be where the spacing is missing. Template strings get concatenated but there's no space in the template string so it gets concatenated together.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions