update node types package to 12 (#4005)

* update node types package to 12

* a couple type issues...

* uncomment linking

package.json

@@ -84,7 +84,7 @@
     ]
   },
   "dependencies": {
-    "@google-cloud/pubsub": "^2.7.0",
+    "@google-cloud/pubsub": "^2.18.4",
     "abort-controller": "^3.0.0",
     "ajv": "^6.12.6",
     "archiver": "^5.0.0",
@@ -130,7 +130,7 @@
     "stream-chain": "^2.2.4",
     "stream-json": "^1.7.3",
     "superstatic": "^7.1.0",
-    "tar": "^4.3.0",
+    "tar": "^6.1.11",
     "tcp-port-used": "^1.0.1",
     "tmp": "0.0.33",
     "triple-beam": "^1.3.0",
@@ -169,7 +169,7 @@
     "@types/marked-terminal": "^3.1.3",
     "@types/mocha": "^9.0.0",
     "@types/multer": "^1.4.3",
-    "@types/node": "^10.17.50",
+    "@types/node": "^12.20.39",
     "@types/node-fetch": "^2.5.7",
     "@types/progress": "^2.0.3",
     "@types/puppeteer": "^5.4.2",
@@ -180,7 +180,7 @@
     "@types/sinon-chai": "^3.2.2",
     "@types/stream-json": "^1.7.2",
     "@types/supertest": "^2.0.6",
-    "@types/tar": "^4.0.0",
+    "@types/tar": "^6.1.1",
     "@types/tcp-port-used": "^1.0.0",
     "@types/tmp": "^0.1.0",
     "@types/triple-beam": "^1.3.0",

scripts/integration-helpers/cli.ts

@@ -23,11 +23,11 @@ export class CLIProcess {
     }
     this.process = p;
 
-    this.process.stdout.on("data", (data: unknown) => {
+    this.process.stdout?.on("data", (data: unknown) => {
       process.stdout.write(`[${this.name} stdout] ` + data);
     });
 
-    this.process.stderr.on("data", (data: unknown) => {
+    this.process.stderr?.on("data", (data: unknown) => {
       console.log(`[${this.name} stderr] ` + data);
     });
 

scripts/integration-helpers/framework.ts

@@ -162,7 +162,7 @@ export class TriggerEndToEndTest {
       return data.includes(ALL_EMULATORS_STARTED_LOG);
     });
 
-    cli.process?.stdout.on("data", (data) => {
+    cli.process?.stdout?.on("data", (data) => {
       /* Functions V1 */
       if (data.includes(RTDB_FUNCTION_LOG)) {
         this.rtdbTriggerCount++;

src/deploy/functions/runtimes/golang/index.ts

@@ -120,7 +120,7 @@ export class Delegate {
       cwd: this.sourceDir,
       stdio: [/* stdin=*/ "ignore", /* stdout=*/ "pipe", /* stderr=*/ "inherit"],
     });
-    childProcess.stdout.on("data", (chunk) => {
+    childProcess.stdout?.on("data", (chunk) => {
       logger.debug(chunk.toString());
     });
     return Promise.resolve(async () => {

src/emulator/downloadableEmulators.ts

@@ -325,11 +325,11 @@ async function _runBinary(
       `${description} logging to ${clc.bold(getLogFileName(emulator.name))}`
     );
 
-    emulator.instance.stdout.on("data", (data) => {
+    emulator.instance.stdout?.on("data", (data) => {
       logger.log("DEBUG", data.toString());
       emulator.stdout.write(data);
     });
-    emulator.instance.stderr.on("data", (data) => {
+    emulator.instance.stderr?.on("data", (data) => {
       logger.log("DEBUG", data.toString());
       emulator.stdout.write(data);
 

src/emulator/functionsEmulator.ts

@@ -107,7 +107,7 @@ export interface FunctionsRuntimeInstance {
   // A function to manually kill the child process as normal cleanup
   shutdown(): void;
   // A function to manually kill the child process in case of errors
-  kill(signal?: string): void;
+  kill(signal?: number): void;
   // Send an IPC message to the child process
   send(args: FunctionsRuntimeArgs): boolean;
 }
@@ -1080,6 +1080,13 @@ export class FunctionsEmulator implements EmulatorInstance {
       stdio: ["pipe", "pipe", "pipe", "ipc"],
     });
 
+    if (!childProcess.stderr) {
+      throw new FirebaseError(`childProcess.stderr is undefined.`);
+    }
+    if (!childProcess.stdout) {
+      throw new FirebaseError(`childProcess.stdout is undefined.`);
+    }
+
     const buffers: {
       [pipe: string]: {
         pipe: stream.Readable;
@@ -1113,7 +1120,7 @@ export class FunctionsEmulator implements EmulatorInstance {
       shutdown: () => {
         childProcess.kill();
       },
-      kill: (signal?: string) => {
+      kill: (signal?: number) => {
         childProcess.kill(signal);
         emitter.emit("log", new EmulatorLog("SYSTEM", "runtime-status", "killed"));
       },

src/emulator/functionsEmulatorRuntime.ts

@@ -638,10 +638,13 @@ async function initializeFirebaseAdminStubs(frb: FunctionsRuntimeBundle): Promis
     .finalize();
 
   // Stub the admin module in the require cache
-  require.cache[adminResolution.resolution] = {
-    exports: proxiedAdminModule,
-    path: path.dirname(adminResolution.resolution),
-  };
+  require.cache[adminResolution.resolution] = Object.assign(
+    require.cache[adminResolution.resolution],
+    {
+      exports: proxiedAdminModule,
+      path: path.dirname(adminResolution.resolution),
+    }
+  );
 
   logDebug("firebase-admin has been stubbed.", {
     adminResolution,
@@ -735,10 +738,13 @@ async function initializeFunctionsConfigHelper(frb: FunctionsRuntimeBundle): Pro
     .finalize();
 
   // Stub the functions module in the require cache
-  require.cache[functionsResolution.resolution] = {
-    exports: proxiedFunctionsModule,
-    path: path.dirname(functionsResolution.resolution),
-  };
+  require.cache[functionsResolution.resolution] = Object.assign(
+    require.cache[functionsResolution.resolution],
+    {
+      exports: proxiedFunctionsModule,
+      path: path.dirname(functionsResolution.resolution),
+    }
+  );
 
   logDebug("firebase-functions has been stubbed.", {
     functionsResolution,

src/emulator/storage/rules/runtime.ts

@@ -152,7 +152,7 @@ export class StorageRulesRuntime {
     });
 
     // This catches errors from the java process (i.e. missing jar file)
-    this._childprocess.stderr.on("data", (buf: Buffer) => {
+    this._childprocess.stderr?.on("data", (buf: Buffer) => {
       const error = buf.toString();
       if (error.includes("jarfile")) {
         throw new FirebaseError(
@@ -166,7 +166,7 @@ export class StorageRulesRuntime {
       }
     });
 
-    this._childprocess.stdout.on("data", (buf: Buffer) => {
+    this._childprocess.stdout?.on("data", (buf: Buffer) => {
       const serializedRuntimeActionResponse = buf.toString("UTF8").trim();
       if (serializedRuntimeActionResponse != "") {
         let rap;
@@ -225,7 +225,7 @@ export class StorageRulesRuntime {
       };
 
       const serializedRequest = JSON.stringify(runtimeActionRequest);
-      this._childprocess?.stdin.write(serializedRequest + "\n");
+      this._childprocess?.stdin?.write(serializedRequest + "\n");
     });
   }
 

src/hosting/proxy.ts

@@ -40,7 +40,7 @@ function makeVary(vary: string | null = ""): string {
  * the Firebase Hosting origin.
  */
 export function proxyRequestHandler(url: string, rewriteIdentifier: string): RequestHandler {
-  return async (req: IncomingMessage, res: ServerResponse, next: () => void): Promise<void> => {
+  return async (req: IncomingMessage, res: ServerResponse, next: () => void): Promise<unknown> => {
     logger.info(`[hosting] Rewriting ${req.url} to ${url} for ${rewriteIdentifier}`);
     // Extract the __session cookie from headers to forward it to the
     // functions cookie is not a string[].

src/test/apiv2.spec.ts

@@ -354,11 +354,11 @@ describe("apiv2", () => {
           res.end(JSON.stringify({ proxied: true }));
         });
         await Promise.all([
-          new Promise((resolve) => {
-            proxyServer.listen(52672, resolve);
+          new Promise<void>((resolve) => {
+            proxyServer.listen(52672, () => resolve());
           }),
-          new Promise((resolve) => {
-            targetServer.listen(52673, resolve);
+          new Promise<void>((resolve) => {
+            targetServer.listen(52673, () => resolve());
           }),
         ]);
       });

src/test/emulators/functionsRuntimeWorker.spec.ts

@@ -32,7 +32,7 @@ class MockRuntimeInstance implements FunctionsRuntimeInstance {
     this.events.emit("exit", { reason: "shutdown" });
   }
 
-  kill(signal?: string): void {
+  kill(signal?: number): void {
     this.events.emit("exit", { reason: "kill" });
   }