Skip to content

Skip empty field names in Firestore. #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 2, 2022
Merged

Skip empty field names in Firestore. #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f37cd1e
Fix Vite errors caused by node-fetch.
yuchenshi Sep 2, 2022
f066953
Add license header.
yuchenshi Sep 2, 2022
3728ffe
Skip empty field names in Firestore.
yuchenshi Sep 2, 2022
431ba96
Fix tests.
yuchenshi Sep 2, 2022
8f6928e
Merge branch 'master' into ys/fix-firestore-empty-fields
yuchenshi Sep 2, 2022
a5f6fa4
Merge branch 'master' into ys/fix-firestore-empty-fields
yuchenshi Sep 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Firestore/DocumentEditor/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ describe('with basic root fields', () => {
await act(async () => {
getByText('add').click();
});
expect(onChange).toHaveBeenCalledWith({ hello: 'world', '': '' });
expect(onChange).toHaveBeenCalledWith({ hello: 'world' });
});

it('removes root-fields', () => {
Expand Down
4 changes: 4 additions & 0 deletions src/components/Firestore/DocumentEditor/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,10 @@ export function denormalize(store: Store, firestore?: Firestore): FirestoreAny {
const field = store.fields[store.uuid];
if (isMapField(field)) {
return field.mapChildren.reduce((acc, curr) => {
if (!curr.name) {
// Skip fields with empty name (not allowed by Firestore SDK anyway).
return acc;
}
acc[curr.name] = denormalize(
{
uuid: curr.valueId,
Expand Down