VSCode: use workspace TS (fixes RMWC importing) #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM, but do we have any idea why things are behaving like that? Is it the |
Contributor
Author
|
Honestly I have no idea. I've tried to google it.. it just fails on the global version. I'll try |
Contributor
Author
|
Tried upgrading WS to 3.8.3 and it also broke. so this is some TS version issue :( |
yuchenshi
approved these changes
Mar 16, 2020
Member
yuchenshi
left a comment
yuchenshi
left a comment
There was a problem hiding this comment.
Tested manually. It turned out to be just typescript version.
What works: 3.6.x
What doesn't work: 3.8.x and 3.7.x (?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.