Skip to content

Buttons/list bgs, dialog polish #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 16, 2020
Merged

Buttons/list bgs, dialog polish #37

merged 14 commits into from
Mar 16, 2020

Conversation

@tstirrat
Copy link
Contributor

@tstirrat tstirrat commented Mar 14, 2020 •
edited
Loading

  • I had to refactor material overrides. Dialogs and anything put into the top of the DOM would not take styles (i.e. buttons on dialogs were CAPITALIZED, vs not elsewhere), so I've moved it into components/common/_material-overrides.scss and ensured it loads after the material imports.
  • I also made all the themes and primary/cancel buttons consistent (unelevated for non primary buttons).
  • Fixed overflow issues on cards (remove .canvas-card)
  • Fixed incorrect theme color in RTDB
  • Dialog border radius is 16px

Screen Shot 2020-03-13 at 5 26 37 PM

Screen Shot 2020-03-13 at 5 26 47 PM

@tstirrat tstirrat changed the title Buttons/list items now have colored bgs on hover Buttons/list bgs, dialog polish Mar 14, 2020
@tstirrat tstirrat requested review from tjlav5 and yuchenshi March 14, 2020 01:02
tjlav5
tjlav5 reviewed Mar 16, 2020
View reviewed changes
@tstirrat tstirrat requested a review from tjlav5 March 16, 2020 19:07
Tim Stirrat added 2 commits March 16, 2020 12:10
Merge branch 'master' into ts-button-list-bg
62a39bd 
* master:
  Refactor database page into DatabaseContainer. (#36)
  Bump acorn from 5.7.3 to 5.7.4 (#39)
Update padding and flexing for db picker
2410fd6
@tstirrat tstirrat merged commit f234a3b into master Mar 16, 2020
@tstirrat tstirrat deleted the ts-button-list-bg branch March 16, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@tjlav5 tjlav5 Awaiting requested review from tjlav5

Assignees

@tjlav5 tjlav5

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tstirrat @tjlav5 @yuchenshi