Skip to content

AI Hybrid Inference: guard against undefined mode #9045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025
Merged

AI Hybrid Inference: guard against undefined mode #9045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
478b4c3
Guard against undefined mode, ie the non-hybrid common case
erikeldridge May 15, 2025
65de23c
Revert default value changes
erikeldridge May 15, 2025
205a25b
Use standalone guard for undefined mode for consistency
erikeldridge May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/ai/src/methods/chrome-adapter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,14 @@ describe('ChromeAdapter', () => {
});
});
describe('isAvailable', () => {
it('returns false if mode is undefined', async () => {
const adapter = new ChromeAdapter();
expect(
await adapter.isAvailable({
contents: []
})
).to.be.false;
});
it('returns false if mode is only cloud', async () => {
const adapter = new ChromeAdapter(undefined, 'only_in_cloud');
expect(
Expand Down Expand Up @@ -239,7 +247,10 @@ describe('ChromeAdapter', () => {
const createStub = stub(languageModelProvider, 'create').returns(
downloadPromise
);
const adapter = new ChromeAdapter(languageModelProvider);
const adapter = new ChromeAdapter(
languageModelProvider,
'prefer_on_device'
);
await adapter.isAvailable({
contents: [{ role: 'user', parts: [{ text: 'hi' }] }]
});
Expand All @@ -260,7 +271,10 @@ describe('ChromeAdapter', () => {
const createStub = stub(languageModelProvider, 'create').returns(
downloadPromise
);
const adapter = new ChromeAdapter(languageModelProvider);
const adapter = new ChromeAdapter(
languageModelProvider,
'prefer_on_device'
);
await adapter.isAvailable({
contents: [{ role: 'user', parts: [{ text: 'hi' }] }]
});
Expand Down
6 changes: 6 additions & 0 deletions packages/ai/src/methods/chrome-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@ export class ChromeAdapter {
* separation of concerns.</p>
*/
async isAvailable(request: GenerateContentRequest): Promise<boolean> {
if (!this.mode) {
logger.debug(
`On-device inference unavailable because mode is undefined.`
);
return false;
}
if (this.mode === 'only_in_cloud') {
logger.debug(
`On-device inference unavailable because mode is "only_in_cloud".`
Expand Down
Loading