Skip to content

Add Cookie Support For Firebase Studio #8986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 70 commits into from
May 1, 2025
Merged

Add Cookie Support For Firebase Studio #8986

merged 70 commits into from
May 1, 2025

Conversation

maneesht
Copy link
Contributor

Currently, when you have a new tab in Firebase Studio, it isn't able to get the cloud workstation's auth cookie, which can cause a redirect.
As a way to bypass this, the Firebase Studio team recommended that we make a request out to each emulator when it is connected to. This PR makes that change.

maneesht and others added 30 commits April 11, 2025 14:30
@maneesht
Added test project to fdc
02c52c6
@maneesht
Fixed formatting
37d0f18
@maneesht
Fix linting
a4d7813
@maneesht
Excluded example integration from tsconfig
170b15a
@maneesht
Fixed example-integration package.json
ec405ae
@maneesht
Added ssl check for firestore
248f654
@maneesht
Added ssl checks for RTDB
14ef1bc
@maneesht
Merge remote-tracking branch 'origin/main' into mtewani/add-ssl-check…
a8fe7de 
…s-use-emulat9or
@maneesht
Removed unnecessary files
df4a115
@maneesht
Removed unnecessary data connect changes
f867d3b
@maneesht
Create gentle-laws-kneel.md
4f23f33
@maneesht
Addressed feedback
e755d8c
@maneesht
Addressed linting issue
ceed5ab
@maneesht
Added functions change
44e2d8b
@maneesht
Removed linting rules
a1b85e2
@maneesht
Updated useEmulator
d67b284
@maneesht
Updated functions signatures
a8b208b
@maneesht
Updated docsite changes
205f9ca
@maneesht
Added tests
4bc9433
@maneesht
Updated docsite
a32ea8b
@maneesht
Fixed formatting
07f44b6
@maneesht
Only checked if user is on cloudworkstation for ssl
d305dec
@maneesht
Removed ssl from storage compat
fc6469a
@maneesht
Revert devsite changes
0a0cb7a
@maneesht
Added return type
25f8be9
@maneesht
Fixed tests
59ab583
@maneesht
Removed changeset
d473c45
@maneesht
Create nice-plants-thank.md
43b4d6d
@maneesht
Fixed test
5538911
@maneesht
Merge branch 'mtewani/auto-ssl-cloudworkstations' of https://github.c…
54f2d7a 
…om/firebase/firebase-js-sdk into mtewani/auto-ssl-cloudworkstations
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 78a4fea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v11.0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 29, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (0e12766)Merge (53507d1)Diff
    browser193 kB193 kB+88 B (+0.0%)
    cordova166 kB166 kB+88 B (+0.1%)
    main147 kB147 kB+87 B (+0.1%)
    module193 kB193 kB+88 B (+0.0%)
    react-native165 kB165 kB+87 B (+0.1%)

  • @firebase/auth-cordova

    TypeBase (0e12766)Merge (53507d1)Diff
    browser166 kB166 kB+88 B (+0.1%)
    module166 kB166 kB+88 B (+0.1%)

  • @firebase/auth-web-extension

    TypeBase (0e12766)Merge (53507d1)Diff
    browser142 kB142 kB+88 B (+0.1%)
    main159 kB159 kB+91 B (+0.1%)
    module142 kB142 kB+88 B (+0.1%)

  • @firebase/auth/internal

    TypeBase (0e12766)Merge (53507d1)Diff
    browser204 kB204 kB+88 B (+0.0%)
    main174 kB174 kB+91 B (+0.1%)
    module204 kB204 kB+88 B (+0.0%)

  • @firebase/data-connect

    TypeBase (0e12766)Merge (53507d1)Diff
    browser21.6 kB21.7 kB+96 B (+0.4%)
    main23.8 kB23.9 kB+95 B (+0.4%)
    module21.6 kB21.7 kB+96 B (+0.4%)

  • @firebase/database

    TypeBase (0e12766)Merge (53507d1)Diff
    browser249 kB249 kB+62 B (+0.0%)
    main254 kB254 kB+61 B (+0.0%)
    module249 kB249 kB+62 B (+0.0%)

  • @firebase/database-compat/standalone

    TypeBase (0e12766)Merge (53507d1)Diff
    main366 kB366 kB+61 B (+0.0%)

  • @firebase/firestore

    TypeBase (0e12766)Merge (53507d1)Diff
    browser384 kB385 kB+99 B (+0.0%)
    main594 kB595 kB+155 B (+0.0%)
    module384 kB385 kB+99 B (+0.0%)
    react-native385 kB385 kB+99 B (+0.0%)

  • @firebase/firestore-lite

    TypeBase (0e12766)Merge (53507d1)Diff
    browser114 kB114 kB+43 B (+0.0%)
    main157 kB157 kB+61 B (+0.0%)
    module114 kB114 kB+43 B (+0.0%)
    react-native114 kB114 kB+44 B (+0.0%)

  • @firebase/functions

    TypeBase (0e12766)Merge (53507d1)Diff
    browser14.0 kB14.1 kB+73 B (+0.5%)
    main14.6 kB14.7 kB+67 B (+0.5%)
    module14.0 kB14.1 kB+73 B (+0.5%)

  • @firebase/storage

    TypeBase (0e12766)Merge (53507d1)Diff
    browser58.4 kB58.4 kB+65 B (+0.1%)
    main59.9 kB60.0 kB+59 B (+0.1%)
    module58.4 kB58.4 kB+65 B (+0.1%)

  • @firebase/util

    TypeBase (0e12766)Merge (53507d1)Diff
    browser23.4 kB23.5 kB+123 B (+0.5%)
    main29.5 kB29.7 kB+193 B (+0.7%)
    module23.4 kB23.5 kB+123 B (+0.5%)

  • bundle

    34 size changes

    TypeBase (0e12766)Merge (53507d1)Diff
    auth (GoogleFBTwitterGitHubPopup)105 kB105 kB+117 B (+0.1%)
    database (Append to a list of data)150 kB150 kB+104 B (+0.1%)
    database (Filtering data)149 kB149 kB+104 B (+0.1%)
    database (Listen for child events)165 kB165 kB+104 B (+0.1%)
    database (Listen for value events + Detach listeners)165 kB165 kB+104 B (+0.1%)
    database (Listen for value events)165 kB165 kB+104 B (+0.1%)
    database (Read data once)165 kB165 kB+104 B (+0.1%)
    database (Save data as transactions)167 kB167 kB+104 B (+0.1%)
    database (Sort data)150 kB151 kB+104 B (+0.1%)
    database (Write data)149 kB149 kB+104 B (+0.1%)
    firestore (CSI Auto Indexing Disable and Delete)275 kB275 kB+102 B (+0.0%)
    firestore (CSI Auto Indexing Enable)275 kB275 kB+102 B (+0.0%)
    firestore (Persistence)306 kB306 kB+102 B (+0.0%)
    firestore (Query Cursors)252 kB252 kB+104 B (+0.0%)
    firestore (Query)249 kB249 kB+104 B (+0.0%)
    firestore (Read data once)237 kB237 kB+104 B (+0.0%)
    firestore (Read Write w Persistence)331 kB331 kB+104 B (+0.0%)
    firestore (Realtime updates)239 kB239 kB+104 B (+0.0%)
    firestore (Transaction)216 kB216 kB+104 B (+0.0%)
    firestore (Write data)216 kB216 kB+104 B (+0.0%)
    firestore-lite (Query Cursors)105 kB105 kB+104 B (+0.1%)
    firestore-lite (Query)101 kB101 kB+104 B (+0.1%)
    firestore-lite (Read data once)76.2 kB76.3 kB+104 B (+0.1%)
    firestore-lite (Transaction)102 kB102 kB+104 B (+0.1%)
    firestore-lite (Write data)85.8 kB85.9 kB+104 B (+0.1%)
    functions (call)34.9 kB35.0 kB+113 B (+0.3%)
    storage (getBytes)42.7 kB42.8 kB+117 B (+0.3%)
    storage (getDownloadURL)44.8 kB44.9 kB+117 B (+0.3%)
    storage (getMetadata)44.2 kB44.3 kB+117 B (+0.3%)
    storage (list + listAll)43.6 kB43.8 kB+117 B (+0.3%)
    storage (updateMetadata)44.5 kB44.6 kB+117 B (+0.3%)
    storage (uploadBytes)49.3 kB49.5 kB+117 B (+0.2%)
    storage (uploadBytesResumable)59.3 kB59.4 kB+117 B (+0.2%)
    storage (uploadString)49.5 kB49.7 kB+117 B (+0.2%)

  • firebase

    15 size changes

    TypeBase (0e12766)Merge (53507d1)Diff
    firebase-auth-compat.js141 kB141 kB+105 B (+0.1%)
    firebase-auth-cordova.js138 kB138 kB+140 B (+0.1%)
    firebase-auth-web-extension.js121 kB121 kB+140 B (+0.1%)
    firebase-auth.js158 kB158 kB+140 B (+0.1%)
    firebase-compat.js797 kB797 kB+178 B (+0.0%)
    firebase-data-connect.js18.1 kB18.2 kB+152 B (+0.8%)
    firebase-database-compat.js164 kB164 kB+93 B (+0.1%)
    firebase-database.js187 kB187 kB+123 B (+0.1%)
    firebase-firestore-compat.js342 kB342 kB+72 B (+0.0%)
    firebase-firestore-lite.js133 kB133 kB+99 B (+0.1%)
    firebase-firestore.js443 kB443 kB+164 B (+0.0%)
    firebase-functions-compat.js10.5 kB10.5 kB+89 B (+0.9%)
    firebase-functions.js14.9 kB15.0 kB+126 B (+0.8%)
    firebase-storage-compat.js40.0 kB40.1 kB+77 B (+0.2%)
    firebase-storage.js46.6 kB46.7 kB+104 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AehXuR30Tb.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 29, 2025 •
edited
Loading

Size Analysis Report 1

This report is too large (195,043 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/C9PADahoSx.html

@maneesht maneesht merged commit 080a90d into main May 1, 2025
44 of 49 checks passed
@maneesht maneesht deleted the mtewani/add-cookie-support-studio branch May 1, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@avolkovi avolkovi avolkovi approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@pashanka pashanka Awaiting requested review from pashanka pashanka is a code owner

@mansisampat mansisampat Awaiting requested review from mansisampat mansisampat is a code owner

@NhienLam NhienLam Awaiting requested review from NhienLam NhienLam is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang tonyjhuang is a code owner

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g aashishpatil-g is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maneesht @google-oss-bot @MarkDuckworth @avolkovi @hsubox76