Review from Tom #8983
Review from Tom #8983
Conversation
|
Vertex AI Mock Responses Check
|
| @@ -3154,7 +3155,7 @@ export function isNull(value: Expr): BooleanExpr; | |||
| /** | |||
| * @beta | |||
| * | |||
| * Creates an expression that checks if a field's value evaluates to 'NaN' (Not a Number). | |||
| * Creates an expression that checks if tbe value of a field is null. | |||
| * | |||
| * ```typescript | |||
There was a problem hiding this comment.
The example needs to be fixed
| @@ -3139,7 +3140,7 @@ export function isAbsent(value: Expr | string): BooleanExpr { | |||
| /** | |||
| * @beta | |||
| * | |||
| * Creates an expression that checks if an expression evaluates to 'NaN' (Not a Number). | |||
| * Creates an expression that checks if tbe result of an expression is null. | |||
There was a problem hiding this comment.
The example needs to be fixed
| @@ -5867,10 +5868,10 @@ export function strConcat( | |||
| * ``` | |||
| * | |||
| * @param fieldName The field name of the map field. | |||
| * @param subField The key to access in the map. | |||
| * @param key The key to access in the map. | |||
There was a problem hiding this comment.
subField doesn't seem quite right within the context of maps. I kinda see where you are going, in which case maybe subFieldName might be more accurate within the context of documents. I personally prefer the word key since it has good programatic meaning.
No description provided.