Skip to content

[FEAT] [WIP] Doc/QuerySnapshot fromJSON. #8960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: ddb-firestore-result-serialization
Choose a base branch
from

Conversation

DellaBitta
Copy link
Contributor

Discussion

WIP. Do not merge.

Add a methods to parse bundles synchronously to extract single DocumentSnapshots or QuerySnapshots containing documents. Hook the new bundle parser up the DocumentSnapshot.fromJSON and QuerySnapshot.fromJSON.

Testing

WIP.

API Changes

WIP.

Copy link

changeset-bot bot commented Apr 22, 2025

⚠️ No Changeset found

Latest commit: 90ade11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v10.0

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 22, 2025

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (c211ea2)Merge (62a83dc)Diff
    browser394 kB398 kB+3.46 kB (+0.9%)
    main608 kB613 kB+4.60 kB (+0.8%)
    module394 kB398 kB+3.46 kB (+0.9%)
    react-native395 kB398 kB+3.46 kB (+0.9%)
  • bundle

    TypeBase (c211ea2)Merge (62a83dc)Diff
    firestore (CSI Auto Indexing Disable and Delete)281 kB303 kB+22.4 kB (+8.0%)
    firestore (CSI Auto Indexing Enable)281 kB303 kB+22.4 kB (+8.0%)
    firestore (Persistence)312 kB331 kB+19.1 kB (+6.1%)
    firestore (Query Cursors)259 kB264 kB+5.87 kB (+2.3%)
    firestore (Query)266 kB268 kB+2.90 kB (+1.1%)
    firestore (Read data once)248 kB256 kB+8.39 kB (+3.4%)
    firestore (Read Write w Persistence)337 kB345 kB+8.15 kB (+2.4%)
    firestore (Realtime updates)260 kB263 kB+2.90 kB (+1.1%)
    firestore (Transaction)225 kB237 kB+12.2 kB (+5.4%)
    firestore (Write data)219 kB240 kB+20.9 kB (+9.5%)
  • firebase

    TypeBase (c211ea2)Merge (62a83dc)Diff
    firebase-compat.js805 kB808 kB+2.60 kB (+0.3%)
    firebase-firestore-compat.js351 kB353 kB+2.60 kB (+0.7%)
    firebase-firestore.js453 kB457 kB+3.46 kB (+0.8%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YcCLillCBQ.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 22, 2025

Size Analysis Report 1

This report is too large (2,193,666 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kjdBzAHMi7.html

@DellaBitta DellaBitta changed the base branch from main to ddb-firestore-result-serialization April 23, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants