Skip to content

For On Device Count Tokens, image input is not supported #8957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

For On Device Count Tokens, image input is not supported #8957

wants to merge 13 commits into from

Conversation

gsiddh
Copy link

@gsiddh gsiddh commented Apr 22, 2025

No description provided.

gsiddh and others added 13 commits April 15, 2025 15:35
@gsiddh
Vaihi add langmodel types. (#8927)
8319ae9 
* Adding LanguageModel types. These are based off https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#full-api-surface-in-web-idl

* Adding LanguageModel types.

* Remove bunch of exports

* yarn formatted

* after lint
@gsiddh @erikeldridge
Define HybridParams (#8935)
96e7dd5 
Co-authored-by: Erik Eldridge <erikeldridge@google.com>
@gsiddh @erikeldridge
Adding smoke test for new hybrid params (#8937)
badaa74 
* Adding smoke test for new hybrid params

* Use the existing name of the model params input

---------

Co-authored-by: Erik Eldridge <erikeldridge@google.com>
@gsiddh @erikeldridge
Moving to in-cloud naming (#8938)
e78c39a 
Co-authored-by: Erik Eldridge <erikeldridge@google.com>
@gsiddh
Moving to string type for the inference mode (#8941)
82838c1
@gsiddh @erikeldridge
Define ChromeAdapter class (#8942)
ff364cd 
Co-authored-by: Erik Eldridge <erikeldridge@google.com>
@erikeldridge
VinF Hybrid Inference: Implement ChromeAdapter (rebased) (#8943)
02c4ba7
@gsiddh
Adding count token impl (#8950)
e069751
@erikeldridge
VinF Hybrid Inference #4: ChromeAdapter in stream methods (rebased) (#…
3d7df8b 
…8949)
@erikeldridge
Define values for Availability enum (#8951)
622916c
@erikeldridge
VinF Hybrid Inference: narrow Chrome input type (#8953)
a46fa4a
@gsiddh
Add image inference support (#8954)
43a69d5 
* Adding image based input for inference

* adding image as input to create language model object
@gsiddh
Reject image input for Count Token on device
6f86c58
@gsiddh gsiddh requested review from a team as code owners April 22, 2025 17:02
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2025

⚠️ No Changeset found

Latest commit: 6f86c58

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gsiddh gsiddh closed this Apr 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v10.0

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (1363ecc)Merge (3fa869f)Diff
    browser34.7 kB39.7 kB+4.96 kB (+14.3%)
    main35.7 kB40.7 kB+4.96 kB (+13.9%)
    module34.7 kB39.7 kB+4.96 kB (+14.3%)

  • firebase

    TypeBase (1363ecc)Merge (3fa869f)Diff
    firebase-vertexai.js28.3 kB31.8 kB+3.56 kB (+12.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QeiA3YpVd6.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

This report is too large (68,271 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oOlkTuhGAw.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsiddh @google-oss-bot @erikeldridge