VinF Hybrid Inference #2: Introduce ChromeAdapter class#8877
Closed
erikeldridge wants to merge 5 commits intoerikeldridge-vertex-apifrom
Closed
VinF Hybrid Inference #2: Introduce ChromeAdapter class#8877erikeldridge wants to merge 5 commits intoerikeldridge-vertex-apifrom
erikeldridge wants to merge 5 commits intoerikeldridge-vertex-apifrom
Conversation
|
Collaborator
Size Report 1Affected Products
Test Logs |
Collaborator
Size Analysis Report 1Affected Products
Test Logs |
Contributor
Vertex AI Mock Responses Check
|
This was referenced Apr 10, 2025
Contributor
Author
|
Closed in favor of #8932 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change minimally introduces a ChromeAdapter class to abstract interactions with Chrome's Prompt API.
To constrain the scope of the change, this only injects the adapter into the generateContent path. If we agree on this approach, a subsequent PR can inject the adapter into the generateContentStream and countTokens paths.
This builds on the API change added by #8874. The diff is against the erikeldridge-vertex-api branch used for that PR. Once we merge that change, we can re-diff this against the integration branch.