V11 - Remove functions node bundle #8507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9da8f06 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (7194d9c) and merge commit (09f226f).Test Logs |
hsubox76
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Looks like functions-compat also has a src/index.node.ts, and it's also referenced in this file's test:node npm script.
hsubox76
reviewed
Sep 20, 2024
| @@ -57,7 +57,7 @@ | |||
| "test:all": "run-p --npm-path npm test:browser test:node", | |||
| "test:browser": "karma start --single-run", | |||
| "test:browser:debug": "karma start --browsers=Chrome --auto-watch", | |||
| "test:node": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'src/{,!(browser)/**/}*.test.ts' --file src/index.node.ts --config ../../config/mocharc.node.js", | |||
| "test:node": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'src/{,!(browser)/**/}*.test.ts' --config ../../config/mocharc.node.js", | |||
There was a problem hiding this comment.
Did you also remove the file itself? It's not showing up as removed in the Github diff for me.
There was a problem hiding this comment.
Done! Sorry about that.
DellaBitta
commented
Sep 23, 2024
| "import": "./dist/node-esm/index.node.esm.js", | ||
| "require": "./dist/index.node.cjs.js" | ||
| "require": "./dist/index.cjs.js", | ||
| "import": "./dist/index.esm2017.js" |
There was a problem hiding this comment.
I know this order is swapped, but now it matches the order of the browser's settings below. :)
hsubox76
reviewed
Sep 23, 2024
hsubox76
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
With the removal of fetch we no long need to create a node bundle for functions. Instead the sourcebase may become isomorphic, so long as we remove the older node sources. And that's what the PR does!
Testing
API Changes
N/A