You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default concurrency value for lerna run is the number of logical CPU cores. This is better than arbitrarily using 4 threads, since different machines may be able to handle more.
The tests were able to run faster on my machine after this, since it has 8 logical cpu cores (os.cpus().length is 8)
The default concurrency value for leran run is the number of logical CPU
cores. This is better than arbitrarily using 4 threads, since different
machines may be able to handle more.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
My only concern is whether this could cause increased flakiness on CI if a CI VM has more than 4 cores, since it seems more tests running concurrently sometimes causes race conditions that lead to flakiness. But I guess we can try it out and revert it if there is any significantly increased flakiness.
The default concurrency value for leran run is the number of logical CPU
cores. This is better than arbitrarily using 4 threads, since different
machines may be able to handle more.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default concurrency value for lerna run is the number of logical CPU cores. This is better than arbitrarily using 4 threads, since different machines may be able to handle more.
The tests were able to run faster on my machine after this, since it has 8 logical cpu cores (
os.cpus().lengthis 8)Related: