Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VertexAI: use updated set of mock responses #8421

Merged
merged 2 commits into from
Aug 13, 2024
Merged

VertexAI: use updated set of mock responses #8421

merged 2 commits into from
Aug 13, 2024

Conversation

tanzimfh
Copy link
Contributor

The set of mock responses were updated to reduce some more duplication: FirebaseExtended/vertexai-sdk-test-data#12

This updates the test code to use the updated version.

Copy link

changeset-bot bot commented Aug 12, 2024

⚠️ No Changeset found

Latest commit: b29f041

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 12, 2024

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 12, 2024

@tanzimfh tanzimfh marked this pull request as ready for review August 12, 2024 21:19
@tanzimfh tanzimfh requested a review from a team as a code owner August 12, 2024 21:19
@tanzimfh tanzimfh requested review from hsubox76 and dlarocque August 12, 2024 21:19
@tanzimfh tanzimfh merged commit cfca9c6 into main Aug 13, 2024
34 of 35 checks passed
@tanzimfh tanzimfh deleted the tanzim/responses branch August 13, 2024 14:23
@firebase firebase locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants