Skip to content

Upgrade webpack to v5 - #7540

Merged
hsubox76 merged 7 commits into
masterfrom
ch-webpack
Aug 14, 2023
Merged

Upgrade webpack to v5#7540
hsubox76 merged 7 commits into
masterfrom
ch-webpack

Conversation

@hsubox76

@hsubox76 hsubox76 commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

See internal doc (go/update-webpack-to-v5-firebase-js-sdk) for issues upgrading so far. This is needed to allow us to upgrade to Node 18+.

Continues #7374

@changeset-bot

changeset-bot Bot commented Aug 8, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3791e52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot

google-oss-bot commented Aug 8, 2023

Copy link
Copy Markdown
Collaborator

@google-oss-bot

google-oss-bot commented Aug 8, 2023

Copy link
Copy Markdown
Collaborator

Size Analysis Report 1

Affected Products

No changes between base commit (f73b24d) and merge commit (2452f98).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ALDMTD3wGM.html

@hsubox76
hsubox76 marked this pull request as ready for review August 9, 2023 17:24
@hsubox76
hsubox76 requested a review from DellaBitta August 9, 2023 17:25

@dwyfrequency dwyfrequency left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/auth/test/helpers/integration/helpers.ts
@hsubox76
hsubox76 merged commit 89fb9fd into master Aug 14, 2023
@hsubox76
hsubox76 deleted the ch-webpack branch August 14, 2023 19:37
@firebase firebase locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants