Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase GHA artifact retention from 2 to 14 days #7495

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jul 25, 2023

Discussion

The test-all workflow builds in one job and runs tests in subsequent jobs, and it uses the upload-artifact and download-artifact GitHub Actions to deliver the build results between the build and test jobs.

The retention period for storing these artifacts was configured for 2 days. Unfortunately this made it difficult to debug failures or re-run flaky tests that failed over the weekend.

This change updates the retention to two weeks, which should be more than enough time.

Note that artifacts might not actually last two weeks. If we exceed our storage limits then the older artifacts will be automatically deleted to create more space for the newer workflow runs.

Testing

CI tests only, as this change affects only a single CI Workflow.
CI Execution. Also re-executed the Firestore test to ensure the build artifact still exists.

API Changes

None.

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

⚠️ No Changeset found

Latest commit: da2a4a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@DellaBitta DellaBitta marked this pull request as ready for review July 25, 2023 15:18
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DellaBitta DellaBitta merged commit 503ca1e into master Jul 25, 2023
26 checks passed
@DellaBitta DellaBitta deleted the ddb-bump-artifact-retention branch July 25, 2023 15:27
@firebase firebase locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants