Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add firefox cross browser test to changed packages #6481

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Add firefox cross browser test to changed packages #6481

merged 4 commits into from
Jul 28, 2022

Conversation

dwyfrequency
Copy link
Contributor

Add Firefox browser to karma and create github action to run tests across Chrome and Firefox.

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: e85dda5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 27, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (f5426a5) and merge commit (1156211).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0hYEab8CrB.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 27, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (f5426a5) and merge commit (1156211).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YtEXSWzyHH.html

@dwyfrequency dwyfrequency marked this pull request as ready for review July 28, 2022 19:00
@dwyfrequency dwyfrequency merged commit 6a17eb6 into master Jul 28, 2022
@dwyfrequency dwyfrequency deleted the jd-firefox-cross-browser branch July 28, 2022 20:27
@firebase firebase locked and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@maneesht maneesht Awaiting requested review from maneesht

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwyfrequency @google-oss-bot @hsubox76