Add function setDefaultEventParameters() to set data that will be logged on every analytics SDK event #6367

dwyfrequency · 2022-06-16T20:11:52Z

Add function to set data that will be set on every event logged from the SDK, including automatic one.

changeset-bot · 2022-06-16T20:11:54Z

🦋 Changeset detected

Latest commit: b016fbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/analytics	Minor
@firebase/analytics-compat	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2022-06-16T20:39:53Z

Size Report ¹

Affected Products

@firebase/analytics
Type Base (578dc58) Merge (77ec975) Diff
browser 19.0 kB 19.6 kB +630 B (+3.3%)
esm5 23.6 kB 24.2 kB +630 B (+2.7%)
main 24.7 kB 25.4 kB +755 B (+3.1%)
module 19.0 kB 19.6 kB +630 B (+3.3%)
@firebase/app-check
Type Base (578dc58) Merge (77ec975) Diff
browser 25.3 kB 25.1 kB -146 B (-0.6%)
esm5 29.9 kB 29.8 kB -152 B (-0.5%)
main 31.1 kB 31.0 kB -154 B (-0.5%)
module 25.3 kB 25.1 kB -146 B (-0.6%)
@firebase/app-check-compat
Type Base (578dc58) Merge (77ec975) Diff
browser 2.27 kB 2.27 kB +1 B (+0.0%)
esm5 2.48 kB 2.48 kB +1 B (+0.0%)
main 2.94 kB 2.94 kB +1 B (+0.0%)
module 2.27 kB 2.27 kB +1 B (+0.0%)

`@firebase/auth`

Type	Base (`578dc58`)	Merge (`77ec975`)	Diff
browser	155 kB	155 kB	+43 B (+0.0%)
cordova	183 kB	183 kB	+43 B (+0.0%)
esm5	203 kB	203 kB	+43 B (+0.0%)
main	148 kB	148 kB	+43 B (+0.0%)
module	155 kB	155 kB	+43 B (+0.0%)
react-native	168 kB	168 kB	+43 B (+0.0%)

@firebase/auth/cordova
Type Base (578dc58) Merge (77ec975) Diff
browser 183 kB 183 kB +43 B (+0.0%)
module 183 kB 183 kB +43 B (+0.0%)
@firebase/auth/internal
Type Base (578dc58) Merge (77ec975) Diff
browser 166 kB 166 kB +43 B (+0.0%)
esm5 216 kB 216 kB +43 B (+0.0%)
main 183 kB 184 kB +43 B (+0.0%)
module 166 kB 166 kB +43 B (+0.0%)
@firebase/auth/react-native
Type Base (578dc58) Merge (77ec975) Diff
browser 168 kB 168 kB +43 B (+0.0%)
module 168 kB 168 kB +43 B (+0.0%)
@firebase/firestore
Type Base (578dc58) Merge (77ec975) Diff
browser 262 kB 262 kB +15 B (+0.0%)
esm5 325 kB 325 kB +15 B (+0.0%)
main 521 kB 522 kB +273 B (+0.1%)
module 262 kB 262 kB +15 B (+0.0%)
react-native 262 kB 262 kB +15 B (+0.0%)

`@firebase/firestore-lite`

Type	Base (`578dc58`)	Merge (`77ec975`)	Diff
browser	80.5 kB	80.5 kB	+15 B (+0.0%)
esm5	96.2 kB	96.2 kB	+15 B (+0.0%)
main	135 kB	135 kB	+78 B (+0.1%)
module	80.5 kB	80.5 kB	+15 B (+0.0%)
react-native	80.7 kB	80.7 kB	+15 B (+0.0%)

@firebase/messaging
Type Base (578dc58) Merge (77ec975) Diff
browser 21.3 kB 21.3 kB +53 B (+0.2%)
esm5 26.6 kB 26.7 kB +53 B (+0.2%)
main 27.3 kB 27.4 kB +53 B (+0.2%)
module 21.3 kB 21.3 kB +53 B (+0.2%)
@firebase/messaging-sw
Type Base (578dc58) Merge (77ec975) Diff
main 30.0 kB 30.1 kB +53 B (+0.2%)
module 23.3 kB 23.3 kB +53 B (+0.2%)
@firebase/remote-config
Type Base (578dc58) Merge (77ec975) Diff
browser 19.2 kB 19.2 kB +1 B (+0.0%)
esm5 24.0 kB 24.0 kB +1 B (+0.0%)
main 25.2 kB 25.2 kB +1 B (+0.0%)
module 19.2 kB 19.2 kB +1 B (+0.0%)
@firebase/util
Type Base (578dc58) Merge (77ec975) Diff
browser 20.5 kB 20.7 kB +168 B (+0.8%)
esm5 21.9 kB 22.0 kB +172 B (+0.8%)
main 26.7 kB 26.9 kB +226 B (+0.8%)
module 20.5 kB 20.7 kB +168 B (+0.8%)

`bundle`

21 size changes

Type	Base (`578dc58`)	Merge (`77ec975`)	Diff
analytics (logEvent)	41.6 kB	41.8 kB	+138 B (+0.3%)
app-check (CustomProvider)	35.4 kB	35.4 kB	+8 B (+0.0%)
app-check (ReCaptchaEnterpriseProvider)	37.6 kB	37.6 kB	+8 B (+0.0%)
app-check (ReCaptchaV3Provider)	37.5 kB	37.5 kB	+8 B (+0.0%)
auth (GoogleFBTwitterGitHubPopup)	90.2 kB	90.3 kB	+41 B (+0.0%)
auth (GooglePopup)	90.0 kB	90.0 kB	+41 B (+0.0%)
auth (GoogleRedirect)	90.2 kB	90.2 kB	+41 B (+0.0%)
firestore (Persistence)	273 kB	273 kB	+6 B (+0.0%)
firestore (Query Cursors)	210 kB	210 kB	+6 B (+0.0%)
firestore (Query)	211 kB	211 kB	+6 B (+0.0%)
firestore (Read data once)	200 kB	200 kB	+6 B (+0.0%)
firestore (Realtime updates)	202 kB	202 kB	+6 B (+0.0%)
firestore (Transaction)	183 kB	184 kB	+15 B (+0.0%)
firestore (Write data)	183 kB	183 kB	+6 B (+0.0%)
firestore-lite (Query Cursors)	210 kB	210 kB	+6 B (+0.0%)
firestore-lite (Query)	210 kB	210 kB	+6 B (+0.0%)
firestore-lite (Read data once)	200 kB	200 kB	+6 B (+0.0%)
firestore-lite (Transaction)	183 kB	184 kB	+15 B (+0.0%)
firestore-lite (Write data)	183 kB	183 kB	+6 B (+0.0%)
messaging (send + receive)	45.1 kB	45.1 kB	+49 B (+0.1%)
remote-config (getAndFetch)	44.2 kB	44.2 kB	+1 B (+0.0%)

`firebase`

17 size changes

Type	Base (`578dc58`)	Merge (`77ec975`)	Diff
firebase-analytics-compat.js	25.6 kB	25.8 kB	+136 B (+0.5%)
firebase-analytics.js	111 kB	113 kB	+1.55 kB (+1.4%)
firebase-app-check-compat.js	22.8 kB	22.8 kB	+29 B (+0.1%)
firebase-app-check.js	90.2 kB	90.9 kB	+670 B (+0.7%)
firebase-auth-compat.js	125 kB	125 kB	+41 B (+0.0%)
firebase-auth-cordova.js	472 kB	472 kB	+58 B (+0.0%)
firebase-auth-react-native.js	495 kB	497 kB	+1.03 kB (+0.2%)
firebase-auth.js	418 kB	418 kB	+58 B (+0.0%)
firebase-compat.js	794 kB	794 kB	+299 B (+0.0%)
firebase-firestore-compat.js	314 kB	314 kB	+15 B (+0.0%)
firebase-firestore-lite.js	845 kB	845 kB	+19 B (+0.0%)
firebase-firestore.js	845 kB	845 kB	+19 B (+0.0%)
firebase-messaging-compat.js	38.1 kB	38.2 kB	+78 B (+0.2%)
firebase-messaging-sw.js	107 kB	107 kB	+71 B (+0.1%)
firebase-messaging.js	106 kB	106 kB	+71 B (+0.1%)
firebase-remote-config-compat.js	27.3 kB	27.3 kB	+2 B (+0.0%)
firebase-remote-config.js	113 kB	113 kB	+1 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/ozxQ66h8L3.html

google-oss-bot · 2022-06-16T20:53:59Z

Size Analysis Report ¹

Affected Products

`@firebase/analytics`

getAnalytics
Size
Type Base (578dc58) Merge (77ec975) Diff
size 9.80 kB 9.94 kB +139 B (+1.4%)
size-with-ext-deps 35.9 kB 36.0 kB +138 B (+0.4%)
initializeAnalytics
Size
Type Base (578dc58) Merge (77ec975) Diff
size 9.69 kB 9.83 kB +138 B (+1.4%)
size-with-ext-deps 35.7 kB 35.8 kB +138 B (+0.4%)
isSupported
Size
Type Base (578dc58) Merge (77ec975) Diff
size 9.58 kB 9.72 kB +138 B (+1.4%)
size-with-ext-deps 35.2 kB 35.4 kB +138 B (+0.4%)
logEvent
Size
Type Base (578dc58) Merge (77ec975) Diff
size 9.44 kB 9.58 kB +138 B (+1.5%)
size-with-ext-deps 35.1 kB 35.2 kB +138 B (+0.4%)
setAnalyticsCollectionEnabled
Size
Type Base (578dc58) Merge (77ec975) Diff
size 9.61 kB 9.75 kB +138 B (+1.4%)
size-with-ext-deps 35.3 kB 35.4 kB +138 B (+0.4%)
setCurrentScreen
Size
Type Base (578dc58) Merge (77ec975) Diff
size 9.69 kB 9.83 kB +138 B (+1.4%)
size-with-ext-deps 35.3 kB 35.5 kB +138 B (+0.4%)

`setDefaultEventParameters`

Size

Type	Base (`578dc58`)	Merge (`77ec975`)	Diff
size	?	9.70 kB	? (?)
size-with-ext-deps	?	35.3 kB	? (?)

Dependency

Type	Base (`578dc58`)	Merge (`77ec975`)	Diff
functions	?	23 dependencies _initializeAnalytics _setDefaultEventParametersForInit attemptFetchDynamicConfigWithRetry factory fetchDynamicConfig fetchDynamicConfigWithRetry findGtagScriptOnPage getHeaders getOrCreateDataLayer gtagOnConfig gtagOnEvent insertScriptTag isRetriableError logEvent logEvent$1 promiseAllSettled registerAnalytics setAbortableTimeout setDefaultEventParameters validateIndexedDB warnOnBrowserContextMismatch wrapGtag wrapOrCreateGtag	?
classes	?	AnalyticsAbortSignal AnalyticsService RetryData	?
variables	?	23 dependencies ANALYTICS_TYPE BASE_INTERVAL_MILLIS DYNAMIC_CONFIG_URL ERRORS ERROR_FACTORY FETCH_TIMEOUT_MILLIS GA_FID_KEY GTAG_URL LONG_RETRY_FACTOR ORIGIN_KEY dataLayerName defaultEventParametersForInit defaultRetryData dynamicConfigPromisesList globalInitDone gtagCoreFunction gtagName initializationPromisesMap logger measurementIdToAppId name version wrappedGtagFunction	?
enums	?		?

External Dependency

Module	Base (`578dc58`)	Merge (`77ec975`)	Diff
`@firebase/app`	?	_registerComponent registerVersion	?
`@firebase/component`	?	Component	?
`@firebase/logger`	?	Logger	?
`@firebase/util`	?	ErrorFactory FirebaseError areCookiesEnabled calculateBackoffMillis getModularInstance isBrowserExtension isIndexedDBAvailable validateIndexedDBOpenable	?

setUserId
Size
Type Base (578dc58) Merge (77ec975) Diff
size 9.67 kB 9.81 kB +138 B (+1.4%)
size-with-ext-deps 35.3 kB 35.5 kB +138 B (+0.4%)
setUserProperties
Size
Type Base (578dc58) Merge (77ec975) Diff
size 9.75 kB 9.89 kB +138 B (+1.4%)
size-with-ext-deps 35.4 kB 35.5 kB +138 B (+0.4%)
settings
Size
Type Base (578dc58) Merge (77ec975) Diff
size 9.57 kB 9.71 kB +138 B (+1.4%)
size-with-ext-deps 35.2 kB 35.4 kB +138 B (+0.4%)

`@firebase/app-check`

CustomProvider
Size
Type Base (578dc58) Merge (77ec975) Diff
size 7.50 kB 7.51 kB +1 B (+0.0%)
size-with-ext-deps 24.9 kB 24.9 kB +1 B (+0.0%)
ReCaptchaEnterpriseProvider
Size
Type Base (578dc58) Merge (77ec975) Diff
size 11.0 kB 11.0 kB +1 B (+0.0%)
size-with-ext-deps 28.2 kB 28.2 kB +1 B (+0.0%)
ReCaptchaV3Provider
Size
Type Base (578dc58) Merge (77ec975) Diff
size 11.0 kB 11.0 kB +1 B (+0.0%)
size-with-ext-deps 28.2 kB 28.2 kB +1 B (+0.0%)
getToken
Size
Type Base (578dc58) Merge (77ec975) Diff
size 7.13 kB 7.13 kB +1 B (+0.0%)
size-with-ext-deps 24.0 kB 24.0 kB +1 B (+0.0%)

`initializeAppCheck`

Size

Type	Base (`578dc58`)	Merge (`77ec975`)	Diff
size	11.1 kB	11.0 kB	-136 B (-1.2%)
size-with-ext-deps	28.5 kB	28.5 kB	+8 B (+0.0%)

Dependency

Type Base (578dc58) Merge (77ec975) Diff

functions

36 dependencies

_activate
addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getDebugState
getDebugToken
getExchangeDebugTokenRequest
getState
getToken$2
initTokenRefresher
initializeAppCheck
initializeDebugMode
internalFactory
isDebugMode
isValid
makeDummyTokenResult
notifyTokenListeners
read
readDebugTokenFromIndexedDB
readOrCreateDebugTokenFromStorage
readTokenFromIndexedDB
readTokenFromStorage
registerAppCheck
removeTokenListener
setState
sleep
uuidv4
write
writeDebugTokenToIndexedDB
writeTokenToIndexedDB
writeTokenToStorage

35 dependencies

_activate
addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getDebugState
getDebugToken
getExchangeDebugTokenRequest
getState
getToken$2
initTokenRefresher
initializeAppCheck
initializeDebugMode
internalFactory
isDebugMode
isValid
makeDummyTokenResult
notifyTokenListeners
read
readDebugTokenFromIndexedDB
readOrCreateDebugTokenFromStorage
readTokenFromIndexedDB
readTokenFromStorage
registerAppCheck
removeTokenListener
setState
sleep
write
writeDebugTokenToIndexedDB
writeTokenToIndexedDB
writeTokenToStorage

- uuidv4

External Dependency

Module	Base (`578dc58`)	Merge (`77ec975`)	Diff
`@firebase/util`	Deferred ErrorFactory base64 getGlobal getModularInstance isIndexedDBAvailable	Deferred ErrorFactory base64 getGlobal getModularInstance isIndexedDBAvailable uuidv4	+ uuidv4

onTokenChanged
Size
Type Base (578dc58) Merge (77ec975) Diff
size 7.23 kB 7.23 kB +1 B (+0.0%)
size-with-ext-deps 24.1 kB 24.1 kB +1 B (+0.0%)
setTokenAutoRefreshEnabled
Size
Type Base (578dc58) Merge (77ec975) Diff
size 7.26 kB 7.26 kB +1 B (+0.0%)
size-with-ext-deps 24.2 kB 24.2 kB +1 B (+0.0%)

@firebase/auth
- browserLocalPersistence
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 34.8 kB 34.8 kB +41 B (+0.1%)
  size-with-ext-deps 54.5 kB 54.5 kB +41 B (+0.1%)
- browserPopupRedirectResolver
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 55.8 kB 55.8 kB +41 B (+0.1%)
  size-with-ext-deps 75.6 kB 75.7 kB +41 B (+0.1%)
- browserSessionPersistence
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 34.8 kB 34.8 kB +41 B (+0.1%)
  size-with-ext-deps 54.5 kB 54.5 kB +41 B (+0.1%)
- getAuth
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 63.5 kB 63.5 kB +41 B (+0.1%)
  size-with-ext-deps 83.9 kB 83.9 kB +41 B (+0.0%)
@firebase/firestore
- addDoc
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 116 kB 116 kB +6 B (+0.0%)
  size-with-ext-deps 176 kB 176 kB +6 B (+0.0%)
- deleteDoc
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 107 kB 107 kB +6 B (+0.0%)
  size-with-ext-deps 167 kB 167 kB +6 B (+0.0%)
- disableNetwork
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 95.2 kB 95.2 kB +6 B (+0.0%)
  size-with-ext-deps 156 kB 156 kB +6 B (+0.0%)
- enableIndexedDbPersistence
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 174 kB 174 kB +6 B (+0.0%)
  size-with-ext-deps 235 kB 235 kB +6 B (+0.0%)
- enableMultiTabIndexedDbPersistence
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 206 kB 206 kB +6 B (+0.0%)
  size-with-ext-deps 267 kB 267 kB +6 B (+0.0%)
- enableNetwork
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 95.1 kB 95.1 kB +6 B (+0.0%)
  size-with-ext-deps 156 kB 156 kB +6 B (+0.0%)
- executeWrite
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 106 kB 106 kB +6 B (+0.0%)
  size-with-ext-deps 166 kB 166 kB +6 B (+0.0%)
- getDoc
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 132 kB 132 kB +6 B (+0.0%)
  size-with-ext-deps 192 kB 192 kB +6 B (+0.0%)
- getDocFromServer
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 132 kB 132 kB +6 B (+0.0%)
  size-with-ext-deps 193 kB 193 kB +6 B (+0.0%)
- getDocs
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 133 kB 133 kB +6 B (+0.0%)
  size-with-ext-deps 194 kB 194 kB +6 B (+0.0%)
- getDocsFromServer
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 133 kB 133 kB +6 B (+0.0%)
  size-with-ext-deps 194 kB 194 kB +6 B (+0.0%)
- loadBundle
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 104 kB 104 kB +6 B (+0.0%)
  size-with-ext-deps 165 kB 165 kB +6 B (+0.0%)
- onSnapshot
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 134 kB 134 kB +6 B (+0.0%)
  size-with-ext-deps 195 kB 195 kB +6 B (+0.0%)
- onSnapshotsInSync
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 124 kB 124 kB +6 B (+0.0%)
  size-with-ext-deps 184 kB 184 kB +6 B (+0.0%)
- runTransaction
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 116 kB 116 kB +15 B (+0.0%)
  size-with-ext-deps 176 kB 176 kB +15 B (+0.0%)
- setDoc
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 115 kB 115 kB +6 B (+0.0%)
  size-with-ext-deps 176 kB 176 kB +6 B (+0.0%)
- updateDoc
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 115 kB 115 kB +6 B (+0.0%)
  size-with-ext-deps 176 kB 176 kB +6 B (+0.0%)
- waitForPendingWrites
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 95.6 kB 95.6 kB +6 B (+0.0%)
  size-with-ext-deps 156 kB 156 kB +6 B (+0.0%)
- writeBatch
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 117 kB 117 kB +6 B (+0.0%)
  size-with-ext-deps 178 kB 178 kB +6 B (+0.0%)
@firebase/messaging
- deleteToken
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 12.7 kB 12.7 kB +49 B (+0.4%)
  size-with-ext-deps 38.2 kB 38.3 kB +49 B (+0.1%)
- getMessaging
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 13.1 kB 13.2 kB +49 B (+0.4%)
  size-with-ext-deps 38.8 kB 38.8 kB +49 B (+0.1%)
- getToken
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 12.6 kB 12.6 kB +49 B (+0.4%)
  size-with-ext-deps 38.1 kB 38.1 kB +49 B (+0.1%)
- isSupported
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 12.9 kB 13.0 kB +49 B (+0.4%)
  size-with-ext-deps 38.4 kB 38.5 kB +49 B (+0.1%)
- onMessage
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 12.7 kB 12.7 kB +49 B (+0.4%)
  size-with-ext-deps 38.2 kB 38.3 kB +49 B (+0.1%)
@firebase/remote-config
- activate
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 10.9 kB 10.9 kB +1 B (+0.0%)
  size-with-ext-deps 36.3 kB 36.3 kB +1 B (+0.0%)
- ensureInitialized
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 10.6 kB 10.6 kB +1 B (+0.0%)
  size-with-ext-deps 36.0 kB 36.0 kB +1 B (+0.0%)
- fetchAndActivate
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 11.5 kB 11.5 kB +1 B (+0.0%)
  size-with-ext-deps 36.9 kB 36.9 kB +1 B (+0.0%)
- fetchConfig
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 11.2 kB 11.2 kB +1 B (+0.0%)
  size-with-ext-deps 36.6 kB 36.6 kB +1 B (+0.0%)
- getAll
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 11.8 kB 11.8 kB +1 B (+0.0%)
  size-with-ext-deps 37.2 kB 37.2 kB +1 B (+0.0%)
- getBoolean
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 11.6 kB 11.6 kB +1 B (+0.0%)
  size-with-ext-deps 37.0 kB 37.0 kB +1 B (+0.0%)
- getNumber
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 11.6 kB 11.6 kB +1 B (+0.0%)
  size-with-ext-deps 37.0 kB 37.0 kB +1 B (+0.0%)
- getRemoteConfig
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 10.7 kB 10.7 kB +1 B (+0.0%)
  size-with-ext-deps 36.2 kB 36.2 kB +1 B (+0.0%)
- getString
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 11.6 kB 11.6 kB +1 B (+0.0%)
  size-with-ext-deps 37.0 kB 37.0 kB +1 B (+0.0%)
- getValue
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 11.6 kB 11.6 kB +1 B (+0.0%)
  size-with-ext-deps 37.0 kB 37.0 kB +1 B (+0.0%)
- isSupported
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 10.7 kB 10.7 kB +1 B (+0.0%)
  size-with-ext-deps 36.1 kB 36.1 kB +1 B (+0.0%)
- setLogLevel
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size 10.8 kB 10.8 kB +1 B (+0.0%)
  size-with-ext-deps 36.2 kB 36.2 kB +1 B (+0.0%)
@firebase/util
- uuidv4
  Size
  Type Base (578dc58) Merge (77ec975) Diff
  size ? 176 B ? (?)
  size-with-ext-deps ? 176 B ? (?)
  Dependency
  Type Base (578dc58) Merge (77ec975) Diff
  functions ? ?
  classes ? ?
  variables ?
  uuidv4
  ?
  enums ? ?

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/lwermB2OQb.html

hsubox76

Looks good, just a few comments. Have @egilmorez review reference doc comment text (I tagged him in a comment at the exact spot).

packages/analytics/src/initialize-analytics.ts

.changeset/silly-panthers-mix.md

packages/analytics/src/functions.ts

hsubox76 · 2022-06-22T16:55:21Z

packages/analytics/src/api.ts

 }
+
+/**
+ * Adds data that will be set on every event logged from the SDK, including automatic one.


@egilmorez Can you review the text here? This comment here should be the only text that will end up in the reference docs.

From me:

one => ones

In "gtag's set command" the "set" should be in quotes or backticks, I think quotes because it's a string not a var

packages/analytics/src/functions.ts

packages/analytics/src/api.ts

egilmorez

Just one suggestion, LG, thanks!

packages/analytics/src/api.ts

Add initial design

52239d7

Update API reports

8399af9

google-oss-bot added the doc-changes PRs that affect docs label Jun 16, 2022

dwyfrequency added 7 commits June 20, 2022 12:43

Update to checking for wrappedGtagFunction

1a11ab9

Add initialize test for gtag set

8ca1bad

Add test for _setDefaultEventParametersForInit()

f3ddac3

Update formating

1046412

Add tests for setDefaultEventParameters

88e214e

remove extra new line

24af319

move defaultEventParametersForInit and funcs to functions file

917f6ab

dwyfrequency changed the title ~~Add initial design for setDefaultEventParameters~~ Add function setDefaultEventParameters() to set data that will be logged on every analytics SDK event Jun 21, 2022

dwyfrequency marked this pull request as ready for review June 21, 2022 20:31

dwyfrequency requested review from allspain and hsubox76 as code owners June 21, 2022 20:31

Add changeset

faf051f

dwyfrequency requested a review from egilmorez as a code owner June 22, 2022 13:10

hsubox76 reviewed Jun 22, 2022

View reviewed changes

packages/analytics/src/functions.ts Outdated Show resolved Hide resolved

hsubox76 reviewed Jun 22, 2022

View reviewed changes

packages/analytics/src/api.ts Show resolved Hide resolved

dwyfrequency added 3 commits June 22, 2022 14:01

Resolve PR comments

92eaf53

Capitalize Analytics in changeset

5c9044f

Remove quotes around Analytics in changeset

16b4816

hsubox76 approved these changes Jun 23, 2022

View reviewed changes

egilmorez approved these changes Jun 24, 2022

View reviewed changes

packages/analytics/src/api.ts Outdated Show resolved Hide resolved

Update setDefaultEventParameters doc string

b016fbc

dwyfrequency merged commit 69e2ee0 into master Jun 24, 2022

dwyfrequency deleted the setDefaultEventParameters branch June 24, 2022 17:31

This was referenced Jul 6, 2022

Version Packages #6415

Merged

Version Packages #6424

Merged

firebase locked and limited conversation to collaborators Jul 25, 2022

Add function setDefaultEventParameters() to set data that will be logged on every analytics SDK event #6367

Add function setDefaultEventParameters() to set data that will be logged on every analytics SDK event #6367

Uh oh!

Conversation

dwyfrequency commented Jun 16, 2022

Uh oh!

changeset-bot bot commented Jun 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

google-oss-bot commented Jun 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

@firebase/analytics

@firebase/app-check

@firebase/app-check-compat

@firebase/auth

@firebase/auth/cordova

@firebase/auth/internal

@firebase/auth/react-native

@firebase/firestore

@firebase/firestore-lite

@firebase/messaging

@firebase/messaging-sw

@firebase/remote-config

@firebase/util

bundle

firebase

Test Logs

Uh oh!

google-oss-bot commented Jun 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report 1

Affected Products

@firebase/analytics

getAnalytics

initializeAnalytics

isSupported

logEvent

setAnalyticsCollectionEnabled

setCurrentScreen

setDefaultEventParameters

setUserId

setUserProperties

settings

@firebase/app-check

CustomProvider

ReCaptchaEnterpriseProvider

ReCaptchaV3Provider

getToken

initializeAppCheck

onTokenChanged

setTokenAutoRefreshEnabled

@firebase/auth

browserLocalPersistence

browserPopupRedirectResolver

browserSessionPersistence

getAuth

@firebase/firestore

addDoc

deleteDoc

disableNetwork

enableIndexedDbPersistence

enableMultiTabIndexedDbPersistence

enableNetwork

executeWrite

getDoc

getDocFromServer

getDocs

getDocsFromServer

loadBundle

onSnapshot

onSnapshotsInSync

runTransaction

setDoc

updateDoc

waitForPendingWrites

writeBatch

@firebase/messaging

changeset-bot bot commented Jun 16, 2022 •

edited

Loading

google-oss-bot commented Jun 16, 2022 •

edited

Loading

Size Report ¹

`@firebase/analytics`

`@firebase/app-check`

`@firebase/app-check-compat`

`@firebase/auth`

`@firebase/auth/cordova`

`@firebase/auth/internal`

`@firebase/auth/react-native`

`@firebase/firestore`

`@firebase/firestore-lite`

`@firebase/messaging`

`@firebase/messaging-sw`

`@firebase/remote-config`

`@firebase/util`

`bundle`

`firebase`

google-oss-bot commented Jun 16, 2022 •

edited

Loading

Size Analysis Report ¹

`@firebase/analytics`

`getAnalytics`

`initializeAnalytics`

`isSupported`

`logEvent`

`setAnalyticsCollectionEnabled`

`setCurrentScreen`

`setDefaultEventParameters`

`setUserId`

`setUserProperties`

`settings`

`@firebase/app-check`

`CustomProvider`

`ReCaptchaEnterpriseProvider`

`ReCaptchaV3Provider`

`getToken`

`initializeAppCheck`

`onTokenChanged`

`setTokenAutoRefreshEnabled`

`@firebase/auth`

`browserLocalPersistence`

`browserPopupRedirectResolver`

`browserSessionPersistence`

`getAuth`

`@firebase/firestore`

`addDoc`

`deleteDoc`

`disableNetwork`

`enableIndexedDbPersistence`

`enableMultiTabIndexedDbPersistence`

`enableNetwork`

`executeWrite`

`getDoc`

`getDocFromServer`

`getDocs`

`getDocsFromServer`

`loadBundle`

`onSnapshot`

`onSnapshotsInSync`

`runTransaction`

`setDoc`

`updateDoc`

`waitForPendingWrites`

`writeBatch`

`@firebase/messaging`

`deleteToken`

`getMessaging`

`getToken`

`isSupported`

`onMessage`

`@firebase/remote-config`

`activate`

`ensureInitialized`

`fetchAndActivate`

`fetchConfig`

`getAll`

`getBoolean`

`getNumber`

`getRemoteConfig`

`getString`