get() server data must be indexed

[jmwski]

If we're getting data from the server, it should be indexed with the query param index.

For the value event registration path, I think the query index is applied using IndexFilter::updateFullNode on the filter attached to the view that the listener sets up front.

Experimentally, even when the query results are already cached (even if they don't have the same path index), as in:

    const things = db.ref().child("things");

    await things.remove();

    things.push().set({ "thing": 1 });
    things.push().set({ "thing": 2 });


    await new Promise((resolve, _) => {
        things.on("value", function (results) {
            resolve();
        })
    });

    things.orderByChild("thing").get().then(function (results) {
        results.forEach(function (node) {
            console.log(JSON.stringify(node));
        });
    }).catch(function (err) {
        console.log("There's an error: " + err);
    })

get() will add the new path index to the CacheNode's index map. It's only in the case where data comes in from the server for the first time that we'd see this issue.

Side note: Looking at repoOnDataUpdate I also noticed that we should probably be calling repoRerunTransactions when server data comes in for the first time (though I'm not certain here).

[changeset-bot]

🦋 Changeset detected

Latest commit: 0ef4c5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/database	Patch
firebase	Patch
@firebase/rules-unit-testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[google-oss-bot]

Size Analysis Report

Affected Products

No changes between base commit (997040a) and head commit (750e2688).

Test Logs

• Base (997040a): https://github.com/firebase/firebase-js-sdk/actions/runs/857993448
• Head (750e2688): https://github.com/firebase/firebase-js-sdk/actions/runs/858519243

[schmidt-sebastian]

Please also add a changelog

[google-oss-bot]

Binary Size Report

Affected SDKs

• @firebase/database

  Type	Base (997040a)	Head (750e2688)	Diff
  browser	296 kB	296 kB	+41 B (+0.0%)
  esm2017	265 kB	265 kB	+41 B (+0.0%)
  main	299 kB	299 kB	+41 B (+0.0%)
  module	296 kB	296 kB	+41 B (+0.0%)

• @firebase/database-exp

  Type	Base (997040a)	Head (750e2688)	Diff
  browser	246 kB	246 kB	+41 B (+0.0%)
  main	278 kB	278 kB	+41 B (+0.0%)
  module	246 kB	246 kB	+41 B (+0.0%)

• firebase

  Type	Base (997040a)	Head (750e2688)	Diff
  firebase-database.js	187 kB	187 kB	+37 B (+0.0%)
  firebase.js	889 kB	889 kB	+37 B (+0.0%)

Test Logs

• Base (997040ac): https://github.com/firebase/firebase-js-sdk/actions/runs/857985048
• Head (750e2688): https://github.com/firebase/firebase-js-sdk/actions/runs/858519243