Skip to content

WIP Tree-Shake Sync Engine Listen #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

WIP Tree-Shake Sync Engine Listen #3537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
453d2f9
Tree-shake LocalStore's Watch implementation
schmidt-sebastian Jul 31, 2020
5d7f272
WIP Tree-Shake Sync Engine Listen
schmidt-sebastian Aug 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
231 changes: 213 additions & 18 deletions packages/firestore/exp/dependencies.json
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 8 additions & 3 deletions packages/firestore/src/core/event_manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ import { debugAssert } from '../util/assert';
import { EventHandler } from '../util/misc';
import { ObjectMap } from '../util/obj_map';
import { canonifyQuery, Query, queryEquals, stringifyQuery } from './query';
import { SyncEngine, SyncEngineListener } from './sync_engine';
import {
SyncEngine,
SyncEngineListener,
listen,
unlisten
} from './sync_engine';
import { OnlineState } from './types';
import { ChangeType, DocumentViewChange, ViewSnapshot } from './view_snapshot';
import { wrapInUserErrorIfRecoverable } from '../util/async_queue';
Expand Down Expand Up @@ -72,7 +77,7 @@ export class EventManager implements SyncEngineListener {

if (firstListen) {
try {
queryInfo.viewSnap = await this.syncEngine.listen(query);
queryInfo.viewSnap = await listen(this.syncEngine, query);
} catch (e) {
const firestoreError = wrapInUserErrorIfRecoverable(
e,
Expand Down Expand Up @@ -116,7 +121,7 @@ export class EventManager implements SyncEngineListener {

if (lastListen) {
this.queries.delete(query);
return this.syncEngine.unlisten(query);
return unlisten(this.syncEngine, query);
}
}

Expand Down
Loading