Add the FCM secret to applicable CI paths. #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKsNo changes between base commit (230cd48) and head commit (ad7908d). Test Logs
|
Feiyang1
approved these changes
May 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: I tried to check in theses changes along with my integration test changes. However, I am getting a
bad credentialresponse from FCM Send Service upon triggering a send request. This is a response thrown when theserver keyis faulty or missing (local tests seems to indicated that my server key is functional). The remaining possible culprits include:a) Secret checked in is somehow wrong (maybe a trailing space? etc) -or-
b) Secrets must already be included in the ci runs prior than using it in a post-commit run -or-
c) Secret is somehow not included into process.Env
This PR is created to examine the validity of hypo b). Hopeful it would resolve the issue 🍺