Update CI Triggers #2763
Merged
Update CI Triggers #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifanyang
reviewed
Mar 19, 2020
.github/workflows/test-all.yml
Outdated
| @@ -1,11 +1,7 @@ | |||
| name: Run All Tests | |||
There was a problem hiding this comment.
Since the other workflow is renamed to "Test Modified Packages", how about also renaming this one to "Test All Packages"?
Feiyang1
reviewed
Mar 19, 2020
.github/workflows/test-all.yml
Outdated
| - master | ||
| types: | ||
| - closed | ||
| push: | ||
| schedule: | ||
| - cron: '0 6,18 * * *' |
There was a problem hiding this comment.
Do we still need the cron job?
There was a problem hiding this comment.
I guess it hasn't been very helpful. Removing.
.github/workflows/test-changed.yml
Outdated
| pull_request: | ||
| branches: | ||
| - '*' | ||
| - '!master' |
There was a problem hiding this comment.
What does excluding master for PR mean? Don't we always create PR against master?
There was a problem hiding this comment.
Yes, I think I was confused about what "branches" means for PR. Fixing.
yifanyang
approved these changes
Mar 19, 2020
Feiyang1
approved these changes
Mar 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously:
Now:
Additionally, we will change the repo settings to ensure "Test Modified Packages" is a required check and "Run All Tests" is optional, so if it runs too many tests and fails a flaky test, it does not block merge.