Run tests only on changed packages on PR/push #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
changed the title
hiranya911
approved these changes
Jan 22, 2020
scripts/run_changed.js
Outdated
| @@ -0,0 +1,83 @@ | |||
| /** | |||
| * @license | |||
| * Copyright 2019 Google Inc. | |||
There was a problem hiding this comment.
Thanks, also fixed this in the template that auto-adds the license headers.
| * @param {Array<string>} pathList | ||
| */ | ||
| async function runTests(pathList) { | ||
| if (!pathList) return; |
There was a problem hiding this comment.
May be log this case: No changes detected in any package
There was a problem hiding this comment.
Good idea, added it to runTestsOnChangedPackages since this function is also used to run the integration tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to run tests only on packages with changed files on PR/push. Entire test suite will continue to run on merge, and twice a day.
Cross-browser tests moved to run only on merge until I can clean up our Saucelabs workflow to make results viewable and useful.