Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress server errors in deleteToken request #2428

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Suppress server errors in deleteToken request #2428

merged 2 commits into from
Dec 10, 2019

Conversation

mmermerkaya
Copy link
Contributor

Band-aid for #2364 until we find and fix the problem.

dwoffinden
dwoffinden approved these changes Dec 10, 2019
View reviewed changes
Copy link

@dwoffinden dwoffinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to test this? :P

packages/messaging/src/controllers/base-controller.ts Show resolved Hide resolved
packages/messaging/src/controllers/base-controller.ts Show resolved Hide resolved
@mmermerkaya mmermerkaya merged commit ff8f854 into master Dec 10, 2019
@mmermerkaya mmermerkaya deleted the mmermerkaya-messaging-suppress-delete branch December 10, 2019 16:53
@hsubox76 hsubox76 added this to the next milestone Dec 10, 2019
@firebase firebase locked and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwoffinden dwoffinden dwoffinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mmermerkaya @dwoffinden @hsubox76