Add repository.directory field to all package.json files
#1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlinnot
requested review from
bojeil-google,
dwoffinden,
Feiyang1,
hiranya911,
hsubox76,
jsdt,
mikelehen,
mmermerkaya,
pinarx,
ryanpbrewster,
schmidt-sebastian,
tonymeng and
wti806
as code owners
packages/app/package.json
Outdated
| "type": "git", | ||
| "url": "https://github.com/firebase/firebase-js-sdk/tree/master/packages/app" | ||
| "url": "https://github.com/firebase/firebase-js-sdk.git", |
There was a problem hiding this comment.
I think this trailing comma is causing issues with the CI tests
npm supports links to `package.json` files that are not in a root of a repostiory by supplying `directory` field in `repository`, see https://docs.npmjs.com/files/package.json.html#repository
merlinnot
force-pushed
the
merlinnot/repository-directory
branch
from
fc23955 to
19d6899
Compare
|
LGTM. Thank you very much for contributing! 👍 |
Feiyang1
approved these changes
Mar 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm supports links to
package.jsonfiles that are not in a root of a repostiory by supplyingdirectoryfield inrepository, see https://docs.npmjs.com/files/package.json.html#repository