Update re2js version#10104
Conversation
🦋 Changeset detectedLatest commit: 8ab39c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the re2js dependency from version 0.4.2 to 2.8.3 in package.json and yarn.lock. It also updates the type definition path in externs.json and simplifies the regex evaluation in expressions.ts by using regex.test(value) instead of regex.matcher(value).find(). There are no review comments, so I have no feedback to provide.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| 'firebase': major | |||
There was a problem hiding this comment.
I will leave it up to the Firestore team to determine whether we can bump re2js at all but if we were to do so, our policy is a patch bump for external dependency bumps (even if the external dependency bump is major), and it should be for "@firebase/firestore" ("firebase" will automatically pick up patch bumps when specified in dependent packages).
There was a problem hiding this comment.
this is what generated yarn changeset
3 participants
Update re2js version, which supported and use highly optimized methods (
test) for search.More info: