fix: add "@firebase/app" as a peerDep in compat packages#10097
Conversation
🦋 Changeset detectedLatest commit: 6644fab The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds @firebase/app as a peer dependency to several Firebase compatibility packages to resolve dependency issues. The reviewer noted that @firebase/database-compat is missing from this update and should also be included to ensure consistency across all compatibility packages.
| '@firebase/functions-compat': patch | ||
| '@firebase/messaging-compat': patch | ||
| '@firebase/storage-compat': patch | ||
| '@firebase/auth-compat': patch |
There was a problem hiding this comment.
It appears that @firebase/database-compat is missing from this pull request. Like the other compatibility packages, @firebase/database-compat depends on its underlying modular package (@firebase/database), which has a peer dependency on @firebase/app. To fully resolve the issue for all compat packages (especially for package managers like PNPM and Yarn PnP), please also add @firebase/app as a peer dependency in packages/database-compat/package.json and include it in this changeset.
| '@firebase/auth-compat': patch | |
| '@firebase/auth-compat': patch | |
| '@firebase/database-compat': patch |
1 participant
This may fix the issue, or part of the issue, in #3707 where compat packages depend on their underlying modular package, which have a peer dependency on
@firebase/appwhich isn't present in the compat package's package.json. This causes issues with some modern package managers like PNPM and Yarn PNP.