Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [DEPRECATED] to off #7846

Open
marcusx2 opened this issue Dec 8, 2023 · 0 comments
Open

Add [DEPRECATED] to off #7846

marcusx2 opened this issue Dec 8, 2023 · 0 comments

Comments

@marcusx2
Copy link

marcusx2 commented Dec 8, 2023

Operating System

macOS

Browser Version

Safari 16.5.2

Firebase SDK Version

10.7.0

Firebase SDK Product:

Database

Describe your project's tooling

index.html with source tag. Just javascript.

Describe the problem

The off method exists but at the same time the documentation says Note: This is not the recommended way to remove a listener. Instead, please use the returned callback function from the respective on* callbacks. which leads me to believe that this method comes from the old v8 api and only still exists for compatibility reasons and to facilitate people moving from v8 to v9. Is there a legitimate case where I should use this method instead of the returned callback from the on methods?

Steps and code to reproduce issue

Already explained.

@marcusx2 marcusx2 added new A new issue that hasn't be categoirzed as question, bug or feature request question labels Dec 8, 2023
@jbalidiong jbalidiong added needs-attention and removed new A new issue that hasn't be categoirzed as question, bug or feature request labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants