heartbeatService.ts: cannot read properties of undefined (reading 'length')

[malk90]

Operating System

Windows >=10

Browser Version

Opera 102.0.0

Firebase SDK Version

10.5.2

Firebase SDK Product:

Analytics, Auth, Messaging, Performance

Describe your project's tooling

React app with webpack, cordova, typescript

Describe the problem

Opera users have repeated errors from time to time, most of all in version 102, but it started with 101

In file /node_modules/@firebase/app/src/heartbeatService.ts line 132 error
Cannot read properties of undefined (reading 'length')

this._heartbeatsCache.heartbeats.length === 0

Steps and code to reproduce issue

firebase-js-sdk/packages/app/src/heartbeatService.ts

Line 132 in 12ad9f1

this._heartbeatsCache.heartbeats.length === 0

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[DellaBitta]

Hi @malk90,

I wasn't able to reproduce this with my own test app. Could you provide a reproducible test app or the code that causes this behavior? Thanks!

[malk90]

hi, no, unfortunately I can’t help with the code, but if you look at the code, you’ll immediately see the error

[DellaBitta]

Hi @malk90,

We still couldn't reproduce this issue, unfortunately. However, we just shipped v10.6.0 which includes some better checks around the state of the HeartBeat object that should avoid the error that you're seeing. Could you please give the new release a test?

If you still encounter issues then could you post a minimum reproducible test case so we can better attempt to reproduce the probelm ourselves? Thanks!

[malk90]

there are significantly fewer errors, perhaps not everyone has switched to the new version yet
there is a similar error in another line:

firebase-js-sdk/packages/app/src/heartbeatService.ts

Line 98 in 12ad9f1

this._heartbeatsCache.heartbeats.some(

I think we need more time, I’ll write back a little later, but I would still add checks if null for 'heartbeatService'. Thanks!

[DellaBitta]

Hi @malk90,

We've put some more protections in the upcoming release of 10.7.0 which should be released soon. I'll post here when it's out. Thanks!

[DellaBitta]

Hi @malk90,

v10.7.0 was released on Monday. Can you check to see if this clears up your issue? Thanks.

[google-oss-bot]

Hey @malk90. We need more information to resolve this issue but there hasn't been an update in 5 weekdays. I'm marking the issue as stale and if there are no new updates in the next 5 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

[DellaBitta]

I'm going to close this issue since we released a change to address this issue and we haven't heard if it's still affecting your app after an upgrade. If you find that the issue persists at a later time, please create a new GitHub issue and link to this one. Thank you!