Skip to content

Commit

Permalink
Run Storage Node tests in CI (#8375)
Browse files Browse the repository at this point in the history
The script that runs the tests in CI accepts a `-s` flag we use to pass
the test command we want to run in CI. We were passing two commands, and
only the first one (`test:browser`) was being run, skipping the Node
tests. Now we only pass one command `test`, which runs both.
  • Loading branch information
dlarocque authored Aug 22, 2024
1 parent 4c2c78b commit c6a8851
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/storage/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
"build:deps": "lerna run --scope @firebase/storage --include-dependencies build",
"dev": "rollup -c -w",
"test": "run-p --npm-path npm test:browser test:node lint",
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:browser test:node",
"test:all": "run-p --npm-path npm test:browser test:node",
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test:all",
"test:browser:unit": "karma start --single-run --unit",
"test:browser:integration": "karma start --single-run --integration",
"test:browser": "karma start --single-run",
Expand Down

0 comments on commit c6a8851

Please sign in to comment.