Skip to content

Fix flaky messaging test #9050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2021
Merged

Fix flaky messaging test #9050

merged 1 commit into from
Dec 6, 2021

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Dec 3, 2021 •
edited
Loading

The flaky test requires internet access. I think it's easiest to increase the expectation timeout time by a few seconds but would like to verify this works.

Update I was not able to repro the flaky behavior seen in the nightlies. I still think it may be worth it to extend expectation wait time and see if this test flakes again in nightlies.

#no-changelog

@google-cla google-cla bot added the cla: yes label Dec 3, 2021
@google-oss-bot
Copy link

google-oss-bot commented Dec 3, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • FirebaseMessaging

    Type Base (aff6113) Head (e35a43d) Diff
    CocoaPods ? 728 kB ? (?)

Test Logs

@google-oss-bot
Copy link

google-oss-bot commented Dec 3, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    SDK overall coverage changed from ? (aff6113) to 63.37% (e35a43d) by ?.

    Click to show coverage changes in 29 files.
    Filename Base (aff6113) Head (e35a43d) Diff
    FIRMessaging.m ? 55.48% ?
    FIRMessagingAPNSInfo.m ? 86.96% ?
    FIRMessagingAnalytics.m ? 80.71% ?
    FIRMessagingAuthKeychain.m ? 85.90% ?
    FIRMessagingAuthService.m ? 92.03% ?
    FIRMessagingBackupExcludedPlist.m ? 85.07% ?
    FIRMessagingCheckinPreferences.m ? 97.03% ?
    FIRMessagingCheckinService.m ? 89.19% ?
    FIRMessagingCheckinStore.m ? 80.92% ?
    FIRMessagingContextManagerService.m ? 66.48% ?
    FIRMessagingExtensionHelper.m ? 78.57% ?
    FIRMessagingKeychain.m ? 93.39% ?
    FIRMessagingLogger.m ? 100.00% ?
    FIRMessagingPendingTopicsList.m ? 89.02% ?
    FIRMessagingPersistentSyncMessage.m ? 38.10% ?
    FIRMessagingPubSub.m ? 52.14% ?
    FIRMessagingRemoteNotificationsProxy.m ? 75.84% ?
    FIRMessagingRmqManager.m ? 57.00% ?
    FIRMessagingSyncMessageManager.m ? 68.89% ?
    FIRMessagingTokenDeleteOperation.m ? 0.00% ?
    FIRMessagingTokenFetchOperation.m ? 75.74% ?
    FIRMessagingTokenInfo.m ? 78.86% ?
    FIRMessagingTokenManager.m ? 35.86% ?
    FIRMessagingTokenOperation.m ? 94.29% ?
    FIRMessagingTokenStore.m ? 66.00% ?
    FIRMessagingTopicOperation.m ? 0.00% ?
    FIRMessagingUtilities.m ? 57.20% ?
    NSDictionary+FIRMessaging.m ? 21.21% ?
    NSError+FIRMessaging.m ? 100.00% ?

Test Logs

ncooke3
ncooke3 commented Dec 3, 2021
View reviewed changes
ncooke3
ncooke3 commented Dec 3, 2021
View reviewed changes
@ncooke3 ncooke3 force-pushed the nc/flakey-messaging branch 3 times, most recently from 4bb04a5 to b9d2bd5 Compare December 6, 2021 16:13
@ncooke3 ncooke3 merged commit 755f55a into master Dec 6, 2021
@ncooke3 ncooke3 deleted the nc/flakey-messaging branch December 6, 2021 18:55
@firebase firebase locked and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@charlotteliang charlotteliang charlotteliang approved these changes

Assignees
No one assigned
Labels
api: messaging cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncooke3 @google-oss-bot @paulb777 @charlotteliang