Skip to content

Add Swift API for recording errors with userInfo parameters #8816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2022

Conversation

sergiocampama
Copy link
Contributor

#8815

This is an additive API change which should have no effect on existing clients.

@google-cla
Copy link

google-cla bot commented Oct 16, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 16, 2021
@sergiocampama
Copy link
Contributor Author

@googlebot I signed it!

@sergiocampama
Copy link
Contributor Author

updating the pr, but highly disappointed on the lack of communications from the firebase team, especially on cases where the work is provided for you

@morganchen12 morganchen12 requested a review from elenadoty April 25, 2022 22:45
@morganchen12
Copy link
Contributor

Hey Sergio, apologies for the slow response. We'll take a look. Thanks for making this PR!

@elenadoty elenadoty requested a review from samedson April 29, 2022 18:13
@ryanwilson
Copy link
Member

Sorry again for the delay Sergio, there are some discussions around whether userInfo should be nullable or not, and if it is, what happens when you pass nil to any other previously set keys when using setCustomValue.

@samedson
Copy link
Contributor

samedson commented May 17, 2022

@sergiocampama we are able to approve this API now. I'm just going to suggest a small addition to the comment and then submit the change.

Could you update the comment

  • @param userInfo Additional parameters to send with the record
  • to be: @param userInfo Additional keys and values to send with the logged error. These parameters are added to Crashlytics global list of keys and values that live with the session.

@sergiocampama
Copy link
Contributor Author

@samedson thanks! I've updated the PR with the comments change and made sure to run the style script for the check to pass.

Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thank you for contributing!

@paulb777 paulb777 added this to the 9.2.0 - M117 milestone May 23, 2022
@paulb777 paulb777 merged commit be5f1fe into firebase:master May 23, 2022
@firebase firebase locked and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants