-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Swift API for recording errors with userInfo parameters #8816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
updating the pr, but highly disappointed on the lack of communications from the firebase team, especially on cases where the work is provided for you |
Hey Sergio, apologies for the slow response. We'll take a look. Thanks for making this PR! |
Sorry again for the delay Sergio, there are some discussions around whether |
@sergiocampama we are able to approve this API now. I'm just going to suggest a small addition to the comment and then submit the change. Could you update the comment
|
@samedson thanks! I've updated the PR with the comments change and made sure to run the style script for the check to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - thank you for contributing!
#8815
This is an additive API change which should have no effect on existing clients.