Skip to content

Adds client version header to Firebase Auth server requests. #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2017
Merged

Adds client version header to Firebase Auth server requests. #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90da901
Sends the SDK version with the "X-Client-Version" HTTP header.
XiangtianDai Jun 8, 2017
957f30f
Reorders the declarations to match the execution order.
XiangtianDai Jun 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Firebase/Auth/Source/RPCs/FIRAuthBackend.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@
#import "../AuthProviders/Phone/FIRPhoneAuthProvider.h"
#endif

/** @var kClientVersionHeader
@brief HTTP header name for the client version.
*/
static NSString *const kClientVersionHeader = @"X-Client-Version";

/** @var kIosBundleIdentifierHeader
@brief HTTP header name for iOS bundle ID.
*/
Expand Down Expand Up @@ -428,6 +433,9 @@ - (void)asyncPostToURL:(NSURL *)URL
completionHandler:(void (^)(NSData *_Nullable, NSError *_Nullable))handler {
NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:URL];
[request setValue:contentType forHTTPHeaderField:@"Content-Type"];
NSString *clientVersion =
[NSString stringWithFormat:@"iOS/FirebaseSDK/%s", FirebaseAuthVersionString];
[request setValue:clientVersion forHTTPHeaderField:kClientVersionHeader];
NSString *bundleID = [[NSBundle mainBundle] bundleIdentifier];
[request setValue:bundleID forHTTPHeaderField:kIosBundleIdentifierHeader];

Expand Down