Skip to content

port Firestore SnapshotVersion in C++ #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 9, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Firestore/Example/Firestore.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@
AB380D04201BC6E400D97691 /* ordered_code_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = AB380D03201BC6E400D97691 /* ordered_code_test.cc */; };
AB38D93020236E21000A432D /* database_info_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = AB38D92E20235D22000A432D /* database_info_test.cc */; };
AB7BAB342012B519001E0872 /* geo_point_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = AB7BAB332012B519001E0872 /* geo_point_test.cc */; };
ABA495BB202B7E80008A7851 /* snapshot_version_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = ABA495B9202B7E79008A7851 /* snapshot_version_test.cc */; };
ABC1D7DC2023A04B00BA84F0 /* credentials_provider_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = AB38D9342023966E000A432D /* credentials_provider_test.cc */; };
ABC1D7DD2023A04F00BA84F0 /* empty_credentials_provider_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = AB38D93620239689000A432D /* empty_credentials_provider_test.cc */; };
ABC1D7DE2023A05300BA84F0 /* user_test.cc in Sources */ = {isa = PBXBuildFile; fileRef = AB38D93220239654000A432D /* user_test.cc */; };
Expand Down Expand Up @@ -346,6 +347,7 @@
AB38D93620239689000A432D /* empty_credentials_provider_test.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = empty_credentials_provider_test.cc; sourceTree = "<group>"; };
AB71064B201FA60300344F18 /* database_id_test.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = database_id_test.cc; sourceTree = "<group>"; };
AB7BAB332012B519001E0872 /* geo_point_test.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = geo_point_test.cc; path = ../../core/test/firebase/firestore/geo_point_test.cc; sourceTree = "<group>"; };
ABA495B9202B7E79008A7851 /* snapshot_version_test.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = snapshot_version_test.cc; sourceTree = "<group>"; };
ABC1D7DF2023A3EF00BA84F0 /* token_test.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = token_test.cc; sourceTree = "<group>"; };
ABC1D7E22023CDC500BA84F0 /* firebase_credentials_provider_test.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = firebase_credentials_provider_test.mm; sourceTree = "<group>"; };
ABF6506B201131F8005F2C74 /* timestamp_test.cc */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = timestamp_test.cc; sourceTree = "<group>"; };
Expand Down Expand Up @@ -584,6 +586,7 @@
B686F2AD2023DDB20028D6BE /* field_path_test.cc */,
AB71064B201FA60300344F18 /* database_id_test.cc */,
AB356EF6200EA5EB0089B766 /* field_value_test.cc */,
ABA495B9202B7E79008A7851 /* snapshot_version_test.cc */,
ABF6506B201131F8005F2C74 /* timestamp_test.cc */,
);
name = model;
Expand Down Expand Up @@ -1329,6 +1332,7 @@
ABC1D7DC2023A04B00BA84F0 /* credentials_provider_test.cc in Sources */,
5492E059202154AB00B64F25 /* FIRQuerySnapshotTests.mm in Sources */,
5492E050202154AA00B64F25 /* FIRCollectionReferenceTests.mm in Sources */,
ABA495BB202B7E80008A7851 /* snapshot_version_test.cc in Sources */,
5492E0A02021552D00B64F25 /* FSTLevelDBMutationQueueTests.mm in Sources */,
54EB764D202277B30088B8F3 /* array_sorted_map_test.cc in Sources */,
5492E03420213FFC00B64F25 /* FSTMemorySpecTests.mm in Sources */,
Expand Down
2 changes: 2 additions & 0 deletions Firestore/core/src/firebase/firestore/model/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ cc_library(
field_path.h
field_value.cc
field_value.h
snapshot_version.cc
snapshot_version.h
resource_path.cc
resource_path.h
timestamp.cc
Expand Down
34 changes: 34 additions & 0 deletions Firestore/core/src/firebase/firestore/model/snapshot_version.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
/*
* Copyright 2018 Google
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#include "Firestore/core/src/firebase/firestore/model/snapshot_version.h"

namespace firebase {
namespace firestore {
namespace model {

SnapshotVersion::SnapshotVersion(const Timestamp& timestamp)
: timestamp_(timestamp) {
}

const SnapshotVersion& SnapshotVersion::None() {
static const SnapshotVersion kNone(Timestamp{});
return kNone;
}

} // namespace model
} // namespace firestore
} // namespace firebase
74 changes: 74 additions & 0 deletions Firestore/core/src/firebase/firestore/model/snapshot_version.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/*
* Copyright 2018 Google
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#ifndef FIRESTORE_CORE_SRC_FIREBASE_FIRESTORE_MODEL_SNAPSHOT_VERSION_H_
#define FIRESTORE_CORE_SRC_FIREBASE_FIRESTORE_MODEL_SNAPSHOT_VERSION_H_

#include "Firestore/core/src/firebase/firestore/model/timestamp.h"

namespace firebase {
namespace firestore {
namespace model {

/**
* A version of a document in Firestore. This corresponds to the version
* timestamp, such as update_time or read_time.
*/
class SnapshotVersion {
public:
explicit SnapshotVersion(const Timestamp& timestamp);

const Timestamp& timestamp() const {
return timestamp_;
}

/** Creates a new version that is smaller than all other versions. */
static const SnapshotVersion& None();

private:
Timestamp timestamp_;
};

/** Compares against another SnapshotVersion. */
inline bool operator<(const SnapshotVersion& lhs, const SnapshotVersion& rhs) {
return lhs.timestamp() < rhs.timestamp();
}

inline bool operator>(const SnapshotVersion& lhs, const SnapshotVersion& rhs) {
return lhs.timestamp() > rhs.timestamp();
}

inline bool operator>=(const SnapshotVersion& lhs, const SnapshotVersion& rhs) {
return lhs.timestamp() >= rhs.timestamp();
}

inline bool operator<=(const SnapshotVersion& lhs, const SnapshotVersion& rhs) {
return lhs.timestamp() <= rhs.timestamp();
}

inline bool operator!=(const SnapshotVersion& lhs, const SnapshotVersion& rhs) {
return lhs.timestamp() != rhs.timestamp();
}

inline bool operator==(const SnapshotVersion& lhs, const SnapshotVersion& rhs) {
return lhs.timestamp() == rhs.timestamp();
}

} // namespace model
} // namespace firestore
} // namespace firebase

#endif // FIRESTORE_CORE_SRC_FIREBASE_FIRESTORE_MODEL_SNAPSHOT_VERSION_H_
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ cc_test(
database_id_test.cc
field_path_test.cc
field_value_test.cc
snapshot_version_test.cc
timestamp_test.cc
resource_path_test.cc
DEPENDS
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
/*
* Copyright 2018 Google
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#include "Firestore/core/src/firebase/firestore/model/snapshot_version.h"

#include "gtest/gtest.h"

namespace firebase {
namespace firestore {
namespace model {

TEST(SnapshotVersion, Getter) {
SnapshotVersion version(Timestamp(123, 456));
EXPECT_EQ(Timestamp(123, 456), version.timestamp());

const SnapshotVersion& no_version = SnapshotVersion::None();
EXPECT_EQ(Timestamp(), no_version.timestamp());
}

TEST(SnapshotVersion, Comparison) {
EXPECT_LT(SnapshotVersion::None(), SnapshotVersion(Timestamp(123, 456)));

EXPECT_LT(SnapshotVersion(Timestamp(123, 456)),
SnapshotVersion(Timestamp(456, 123)));
EXPECT_GT(SnapshotVersion(Timestamp(456, 123)),
SnapshotVersion(Timestamp(123, 456)));
EXPECT_LE(SnapshotVersion(Timestamp(123, 456)),
SnapshotVersion(Timestamp(456, 123)));
EXPECT_LE(SnapshotVersion(Timestamp(123, 456)),
SnapshotVersion(Timestamp(123, 456)));
EXPECT_GE(SnapshotVersion(Timestamp(456, 123)),
SnapshotVersion(Timestamp(123, 456)));
EXPECT_GE(SnapshotVersion(Timestamp(123, 456)),
SnapshotVersion(Timestamp(123, 456)));
EXPECT_EQ(SnapshotVersion(Timestamp(123, 456)),
SnapshotVersion(Timestamp(123, 456)));
EXPECT_NE(SnapshotVersion(Timestamp(123, 456)),
SnapshotVersion(Timestamp(456, 123)));
}

} // namespace model
} // namespace firestore
} // namespace firebase