Skip to content

Changed actionCodeOperation types #14668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025
+9 −8
Merged

Changed actionCodeOperation types #14668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2412987
Changed actionCodeOperation types
rizafran Apr 7, 2025
1ce68ca
Changed requestType from VERIFY_EMAIL to verifyEmail
rizafran Apr 8, 2025
27a7834
Updated changelog
rizafran Apr 9, 2025
f5c445b
Merge branch 'main' into auth-actionCodeOp
rizafran Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion FirebaseAuth/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Unreleased
- [fixed] Fix a `fatalError` unenrolling from MFA. An invalid user token now throws an
`invalidUserToken` error instead of crashing. (#14663)
- [fixed] Fix the parameter from "languageCode" to "lang" in ActionCodeURL (#14664)
- [fixed] Fix the parameter from "languageCode" to "lang" in ActionCodeURL. (#14664)
- [fixed] Fix the parameters for requestType in ActionCodeOperation. (#14665)

# 11.9.0
- [changed] Using reCAPTCHA Enterprise and Firebase Auth requires reCAPTCHA
Expand Down
12 changes: 6 additions & 6 deletions FirebaseAuth/Sources/Swift/ActionCode/ActionCodeInfo.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ import Foundation
/// - Returns: The corresponding ActionCodeOperation for the supplied request type.
class func actionCodeOperation(forRequestType requestType: String?) -> ActionCodeOperation {
switch requestType {
case "PASSWORD_RESET": return .passwordReset
case "VERIFY_EMAIL": return .verifyEmail
case "RECOVER_EMAIL": return .recoverEmail
case "EMAIL_SIGNIN": return .emailLink
case "VERIFY_AND_CHANGE_EMAIL": return .verifyAndChangeEmail
case "REVERT_SECOND_FACTOR_ADDITION": return .revertSecondFactorAddition
case "resetPassword": return .passwordReset
case "verifyEmail": return .verifyEmail
case "recoverEmail": return .recoverEmail
case "signIn": return .emailLink
case "verifyAndChangeEmail": return .verifyAndChangeEmail
case "revertSecondFactorAddition": return .revertSecondFactorAddition
default: return .unknown
}
}
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Tests/Unit/AuthTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ class AuthTests: RPCBaseTests {
*/
func testCheckActionCodeSuccess() throws {
let kNewEmail = "newEmail@example.com"
let verifyEmailRequestType = "VERIFY_EMAIL"
let verifyEmailRequestType = "verifyEmail"
let expectation = self.expectation(description: #function)

// 1. Setup respond block to test and fake send request.
Expand Down
Loading