Fix nightlies #14560
Fix nightlies #14560
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @paulb777, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an issue with the nightly builds, as indicated by the title and the linked issue #14559. The changes involve modifications to two YAML files that define the CI/CD workflows: .github/workflows/firebase_app_check.yml and .github/workflows/release.yml. The changes in firebase_app_check.yml add a step to install the visionOS platform if the target is 'visionOS spm'. The changes in release.yml update the runs-on value from macos-14 to macos-15 for two jobs.
Highlights
- visionOS Support: The pull request adds a step to install the visionOS platform in the
firebase_app_check.ymlworkflow when the target is 'visionOS spm', ensuring the necessary SDK is available for testing. - macOS Version Update: The pull request updates the
runs-onvalue inrelease.ymlfrommacos-14tomacos-15for thespecs_releasingandreleasejobs, potentially to align with updated infrastructure or toolchain requirements.
Changelog
- .github/workflows/firebase_app_check.yml
- Added a step to install the visionOS platform if the target is 'visionOS spm'. Specifically, lines 160-162 were added to conditionally download the visionOS platform using
xcodebuild.
- Added a step to install the visionOS platform if the target is 'visionOS spm'. Specifically, lines 160-162 were added to conditionally download the visionOS platform using
- .github/workflows/release.yml
- Updated the
runs-onvalue frommacos-14tomacos-15for thespecs_releasingjob (line 77). - Updated the
runs-onvalue frommacos-14tomacos-15for thereleasejob (line 114).
- Updated the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
Xcode was originally named Project Builder when it was first released as part of NeXTSTEP.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request updates the macOS version for the release workflow and adds a step to install visionOS in the firebase_app_check workflow. These changes seem reasonable for supporting newer platforms and maintaining compatibility. However, it's important to verify the changes to ensure they don't introduce any regressions or compatibility issues.
Summary of Findings
- macOS version update: The
runs-onfield in therelease.ymlworkflow has been updated frommacos-14tomacos-15. This change should be verified to ensure compatibility and stability with the new macOS version. - visionOS installation: A new step has been added to the
firebase_app_check.ymlworkflow to install visionOS if the target isvisionOS spm. This addition should be verified to ensure that the visionOS platform is correctly set up for testing.
Merge Readiness
The pull request appears to be making necessary updates for platform compatibility. However, given the potential impact of updating the macOS version and adding visionOS support, thorough testing is recommended before merging. I am unable to approve this pull request, and other reviewers should review and approve this code before merging.
|
With Xcode 15.2, I was able to reproduce the warning in Swift 5: Not sure I see a way around it though... |
|
There is less than a month remaining of app store support for Xcode 15, so I'm fine to disregard. |
Fix #14559