Skip to content

[Database] Mark 'FIRDataSnapshot' as Sendable #14439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2025
Merged

[Database] Mark 'FIRDataSnapshot' as Sendable #14439

merged 3 commits into from
Feb 10, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Feb 10, 2025

Fix #14369

#no-changelog

Copy link
Contributor

Apple API Diff Report

Commit: 16f6b14
Last updated: Mon Feb 10 13:36 PST 2025
View workflow logs & download artifacts


FirebaseDatabase

Classes

[MODIFIED] FIRDataSnapshot
[MODIFIED] FIRDataSnapshot
Swift:
+  class DataSnapshot : NSObject , @unchecked Sendable
-  class DataSnapshot : NSObject
-    func childSnapshot ( forPath childPathString : String ) -> DataSnapshot
-    func hasChild ( _ childPathString : String ) -> Bool
-    func hasChildren () -> Bool
-    func exists () -> Bool
-    func valueInExportFormat () -> Any ?
-    var value : Any ? { get }
-    var childrenCount : UInt { get }
-    var ref : FIRDatabaseReference { get }
-    var key : String { get }
-    var children : NSEnumerator { get }
-    var priority : Any ? { get }
Objective-C:
+  @interface FIRDataSnapshot : NSObject
-  @interface FIRDataSnapshot : NSObject
-    - ( nonnull FIRDataSnapshot * ) childSnapshotForPath : ( nonnull NSString * ) childPathString ;
-    - ( BOOL ) hasChild :( nonnull NSString * ) childPathString ;
-    - ( BOOL ) hasChildren ;
-    - ( BOOL ) exists ;
-    - ( id _Nullable ) valueInExportFormat ;
-    @property ( nonatomic , strong , readonly , nullable ) id value ;
-    @property ( nonatomic , readonly ) NSUInteger childrenCount ;
-    @property ( nonatomic , strong , readonly ) FIRDatabaseReference * _Nonnull ref ;
-    @property ( nonatomic , strong , readonly ) NSString * _Nonnull key ;
-    @property ( nonatomic , strong , readonly ) NSEnumerator < FIRDataSnapshot *> * _Nonnull children ;
-    @property ( nonatomic , strong , readonly , nullable ) id priority ;

@ncooke3 ncooke3 merged commit 1fe5229 into main Feb 10, 2025
46 checks passed
@ncooke3 ncooke3 deleted the nc/sendable-db branch February 10, 2025 22:32
@firebase firebase locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Making Model Objects Sendable
3 participants