Skip to content

Conversation

@andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Jan 16, 2025

Added an internal constructor for RequestOptions that supports specifying an API version (e.g., v1 or v1beta).

See go/firebase-vertex-set-api-version (Google-internal only) for more details.

#14405
#no-changelog

@andrewheard
Copy link
Contributor Author

Removed ExpressibleByStringLiteral conformance for APIVersion since we don't currently have a use-case where using the static properties APIVersion.v1 and APIVersion.v1beta would not be sufficient.

Adding ExpressibleByStringLiteral conformance later, or a static func custom(_ versionIdentifier: String), wouldn't be breaking changes so they've been left out for now.

@andrewheard andrewheard changed the title [Vertex AI] Add apiVersion parameter to RequestOptions [Vertex AI] Add internal apiVersion parameter to RequestOptions Jan 30, 2025
@andrewheard andrewheard marked this pull request as ready for review January 30, 2025 22:40
@andrewheard andrewheard requested a review from paulb777 January 30, 2025 22:40
@andrewheard andrewheard merged commit f946592 into main Jan 30, 2025
38 checks passed
@andrewheard andrewheard deleted the ah/vertex-api-version branch January 30, 2025 22:57
@firebase firebase locked and limited conversation to collaborators Mar 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants