Skip to content

[Auth] Mark AuthRequestConfiguration as final and reduce its mutability #14147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[Auth] Mark AuthRequestConfiguration as final and reduce its mutability #14147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions FirebaseAuth/Sources/Swift/Backend/AuthBackend.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ final class AuthBackend: AuthBackendProtocol {

var request = URLRequest(url: url)
request.setValue(contentType, forHTTPHeaderField: "Content-Type")
let additionalFrameworkMarker = requestConfiguration
.additionalFrameworkMarker ?? "FirebaseCore-iOS"
let additionalFrameworkMarker = requestConfiguration.additionalFrameworkMarker
let clientVersion = "iOS/FirebaseSDK/\(FirebaseVersion())/\(additionalFrameworkMarker)"
request.setValue(clientVersion, forHTTPHeaderField: "X-Client-Version")
request.setValue(Bundle.main.bundleIdentifier, forHTTPHeaderField: "X-Ios-Bundle-Identifier")
Expand Down
6 changes: 3 additions & 3 deletions FirebaseAuth/Sources/Swift/Backend/AuthRequestConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import FirebaseCoreExtension

/// Defines configurations to be added to a request to Firebase Auth's backend.
@available(iOS 13, tvOS 13, macOS 10.15, macCatalyst 13, watchOS 7, *)
class AuthRequestConfiguration {
final class AuthRequestConfiguration {
/// The Firebase Auth API key used in the request.
let apiKey: String

Expand All @@ -33,13 +33,13 @@ class AuthRequestConfiguration {
weak var auth: Auth?

/// The heartbeat logger used to add heartbeats to the corresponding request's header.
var heartbeatLogger: FIRHeartbeatLoggerProtocol?
let heartbeatLogger: FIRHeartbeatLoggerProtocol?

/// The appCheck is used to generate a token.
var appCheck: AppCheckInterop?

/// Additional framework marker that will be added as part of the header of every request.
var additionalFrameworkMarker: String?
let additionalFrameworkMarker: String = "FirebaseCore-iOS"

/// If set, the local emulator host and port to point to instead of the remote backend.
var emulatorHostAndPort: String?
Expand Down
Loading