Skip to content

Add MFA view controller and support MFA #14111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 19, 2024
Merged

Add MFA view controller and support MFA #14111

merged 5 commits into from
Nov 19, 2024

Conversation

@Xiaoshouzi-gh
Copy link
Contributor

@Xiaoshouzi-gh Xiaoshouzi-gh commented Nov 13, 2024 •
edited
Loading

Added MFA sub views and attached to idp and email provider sign in flows.

#no-changelog

@google-oss-bot
Copy link

google-oss-bot commented Nov 13, 2024

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@Xiaoshouzi-gh Xiaoshouzi-gh marked this pull request as ready for review November 19, 2024 17:40
@Xiaoshouzi-gh Xiaoshouzi-gh changed the title Add MFA view controller and support MFA on google sign-in Add MFA view controller and support MFA Nov 19, 2024
@Xiaoshouzi-gh Xiaoshouzi-gh merged commit 380a861 into main Nov 19, 2024
55 checks passed
@Xiaoshouzi-gh Xiaoshouzi-gh deleted the auth-mfa-sample branch November 19, 2024 18:15
abub02
abub02 reviewed Nov 20, 2024
View reviewed changes
Copy link

@abub02 abub02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

abub02
abub02 reviewed Nov 20, 2024
View reviewed changes
Copy link

@abub02 abub02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

abub02
abub02 reviewed Nov 20, 2024
View reviewed changes
Copy link

@abub02 abub02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H

abub02
abub02 reviewed Nov 20, 2024
View reviewed changes
Copy link

@abub02 abub02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K

abub02
abub02 reviewed Nov 20, 2024
View reviewed changes
Copy link

@abub02 abub02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K

@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

+1 more reviewer

@abub02 abub02 abub02 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: auth

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Xiaoshouzi-gh @google-oss-bot @ncooke3 @abub02