Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: enhance firebase in app messaging comments #13790

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ - (void)attemptUploading {
* Note that there is a chance that the app crashes before we can
* call pushRecords: on the logStorage below which means we lost
* these log records permanently. This is a trade-off between handling
* duplicate records on server side vs taking the risk of lossing
* duplicate records on server side vs taking the risk of losing
* data. This implementation picks the latter.
*/
FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM260007",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ - (void)viewDidLayoutSubviews {

// Calculate the size of the image view under the constraints:
// 1 Retain the image ratio
// 2 Have at least 30 point of margines around four sides of the image view
// 2 Have at least 30 point of margins around four sides of the image view

CGFloat minimalMargine = 30; // 30 points
CGFloat maxImageViewWidth = self.view.window.frame.size.width - minimalMargine * 2;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ - (void)layoutFineTuneInPortraitMode {
"with frame height as %lf",
heightCalcReference, self.view.window.frame.size.height);

// this makes sure titleLable gets correct width to be ready for later's height estimate for the
// this makes sure titleLabel gets correct width to be ready for later's height estimate for the
// text & button column
[self.messageCardView layoutIfNeeded];

Expand Down Expand Up @@ -403,7 +403,7 @@ - (void)layoutFineTuneInLandscapeMode {
self.cardLeadingMarginInLandscapeMode.constant = self.view.window.frame.size.width / 5;
}

// this makes sure titleLable gets correct width to be ready for later's height estimate for the
// this makes sure titleLabel gets correct width to be ready for later's height estimate for the
// text & button column
[self.messageCardView layoutIfNeeded];

Expand Down
2 changes: 1 addition & 1 deletion FirebaseInAppMessaging/Sources/DefaultUI/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FirebaseInAppMessagingDisplay is the default UI implementation from Firebase for
rendering In-App Messaging messges to end users.
rendering In-App Messaging messages to end users.

Apps can also provide custom UI implementation to replace it. Check out our guides
for details.
Loading